[PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks

Richard Fitzgerald posted 2 patches 3 weeks, 4 days ago
drivers/soundwire/slave.c           |  1 +
sound/soc/sdw_utils/soc_sdw_utils.c | 43 ++++++++++++++++++++++++++++-
2 files changed, 43 insertions(+), 1 deletion(-)
[PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks
Posted by Richard Fitzgerald 3 weeks, 4 days ago
This series fixes a problem with soc_sdw_utils.c calling the wrong
codec init callbacks, because it assumed that the DAI name could be
used to uniquely identify the codec. This isn't the case, especially
on SDCA which is a generic driver for many parts.

The second patch is the actual fix.
The first patch is needed to add a missing export to SoundWire core.

Richard Fitzgerald (2):
  soundwire: Add missing EXPORT for sdw_slave_type
  ASoC: sdw_utils: Call init callbacks on the correct codec DAI

 drivers/soundwire/slave.c           |  1 +
 sound/soc/sdw_utils/soc_sdw_utils.c | 43 ++++++++++++++++++++++++++++-
 2 files changed, 43 insertions(+), 1 deletion(-)

-- 
2.47.3
Re: [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks
Posted by Mark Brown 3 weeks, 2 days ago
On Mon, 12 Jan 2026 14:07:55 +0000, Richard Fitzgerald wrote:
> This series fixes a problem with soc_sdw_utils.c calling the wrong
> codec init callbacks, because it assumed that the DAI name could be
> used to uniquely identify the codec. This isn't the case, especially
> on SDCA which is a generic driver for many parts.
> 
> The second patch is the actual fix.
> The first patch is needed to add a missing export to SoundWire core.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] soundwire: Add missing EXPORT for sdw_slave_type
      commit: 1ddbcb910a06f53fc2b14e1743c6ad4ccfd7107f
[2/2] ASoC: sdw_utils: Call init callbacks on the correct codec DAI
      commit: 5b027c74f3ee8979193c50d31187edfa31acc0db

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks
Posted by Charles Keepax 3 weeks, 4 days ago
On Mon, Jan 12, 2026 at 02:07:55PM +0000, Richard Fitzgerald wrote:
> This series fixes a problem with soc_sdw_utils.c calling the wrong
> codec init callbacks, because it assumed that the DAI name could be
> used to uniquely identify the codec. This isn't the case, especially
> on SDCA which is a generic driver for many parts.
> 
> The second patch is the actual fix.
> The first patch is needed to add a missing export to SoundWire core.
> 
> Richard Fitzgerald (2):
>   soundwire: Add missing EXPORT for sdw_slave_type
>   ASoC: sdw_utils: Call init callbacks on the correct codec DAI
> 
>  drivers/soundwire/slave.c           |  1 +
>  sound/soc/sdw_utils/soc_sdw_utils.c | 43 ++++++++++++++++++++++++++++-
>  2 files changed, 43 insertions(+), 1 deletion(-)

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles
Re: [PATCH 0/2] ASoC: Fix sdw_utils calling wrong codec init callbacks
Posted by Pierre-Louis Bossart 3 weeks, 3 days ago
On 1/13/26 12:12, Charles Keepax wrote:
> On Mon, Jan 12, 2026 at 02:07:55PM +0000, Richard Fitzgerald wrote:
>> This series fixes a problem with soc_sdw_utils.c calling the wrong
>> codec init callbacks, because it assumed that the DAI name could be
>> used to uniquely identify the codec. This isn't the case, especially
>> on SDCA which is a generic driver for many parts.
>>
>> The second patch is the actual fix.
>> The first patch is needed to add a missing export to SoundWire core.
>>
>> Richard Fitzgerald (2):
>>   soundwire: Add missing EXPORT for sdw_slave_type
>>   ASoC: sdw_utils: Call init callbacks on the correct codec DAI
>>
>>  drivers/soundwire/slave.c           |  1 +
>>  sound/soc/sdw_utils/soc_sdw_utils.c | 43 ++++++++++++++++++++++++++++-
>>  2 files changed, 43 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

It's not obvious from the patchset title that the first patch probably needs Vinod's Acked-by tag