arch/x86/coco/sev/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
On Sat, Dec 20, 2025 at 03:25:46PM +0100, Julia Lawall wrote:
> cocci warnings: (new ones prefixed by >>)
> >> arch/x86/coco/sev/core.c:2838:12-13: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 2837)
From: "Borislav Petkov (AMD)" <bp@alien8.de>
Date: Mon, 12 Jan 2026 12:37:49 +0100
Use the proper helper instead of an open-coded variant.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202512202235.WHPQkLZu-lkp@intel.com
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
arch/x86/coco/sev/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
index 379e0c09c7f3..38dad3f5f491 100644
--- a/arch/x86/coco/sev/core.c
+++ b/arch/x86/coco/sev/core.c
@@ -1632,8 +1632,7 @@ void snp_msg_free(struct snp_msg_desc *mdesc)
free_shared_pages(mdesc->request, sizeof(struct snp_guest_msg));
iounmap((__force void __iomem *)mdesc->secrets);
- memset(mdesc, 0, sizeof(*mdesc));
- kfree(mdesc);
+ kfree_sensitive(mdesc);
}
EXPORT_SYMBOL_GPL(snp_msg_free);
--
2.51.0
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteOn 1/12/26 05:41, Borislav Petkov wrote: > On Sat, Dec 20, 2025 at 03:25:46PM +0100, Julia Lawall wrote: >> cocci warnings: (new ones prefixed by >>) >>>> arch/x86/coco/sev/core.c:2838:12-13: WARNING opportunity for kfree_sensitive/kvfree_sensitive (memset at line 2837) > > From: "Borislav Petkov (AMD)" <bp@alien8.de> > Date: Mon, 12 Jan 2026 12:37:49 +0100 > > Use the proper helper instead of an open-coded variant. > > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Julia Lawall <julia.lawall@inria.fr> > Closes: https://lore.kernel.org/r/202512202235.WHPQkLZu-lkp@intel.com > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com> > --- > arch/x86/coco/sev/core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c > index 379e0c09c7f3..38dad3f5f491 100644 > --- a/arch/x86/coco/sev/core.c > +++ b/arch/x86/coco/sev/core.c > @@ -1632,8 +1632,7 @@ void snp_msg_free(struct snp_msg_desc *mdesc) > free_shared_pages(mdesc->request, sizeof(struct snp_guest_msg)); > iounmap((__force void __iomem *)mdesc->secrets); > > - memset(mdesc, 0, sizeof(*mdesc)); > - kfree(mdesc); > + kfree_sensitive(mdesc); > } > EXPORT_SYMBOL_GPL(snp_msg_free); >
The following commit has been merged into the x86/sev branch of tip:
Commit-ID: af05e558988ed004a20fc4de7d0f80cfbba663f0
Gitweb: https://git.kernel.org/tip/af05e558988ed004a20fc4de7d0f80cfbba663f0
Author: Borislav Petkov (AMD) <bp@alien8.de>
AuthorDate: Mon, 12 Jan 2026 12:37:49 +01:00
Committer: Borislav Petkov (AMD) <bp@alien8.de>
CommitterDate: Tue, 20 Jan 2026 11:23:28 +01:00
x86/sev: Use kfree_sensitive() when freeing a SNP message descriptor
Use the proper helper instead of an open-coded variant.
Closes: https://lore.kernel.org/r/202512202235.WHPQkLZu-lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
Link: https://patch.msgid.link/20260112114147.GBaWTd-8HSy_Xp4S3X@fat_crate.local
---
arch/x86/coco/sev/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c
index a059e00..1b86f48 100644
--- a/arch/x86/coco/sev/core.c
+++ b/arch/x86/coco/sev/core.c
@@ -1632,8 +1632,7 @@ void snp_msg_free(struct snp_msg_desc *mdesc)
free_shared_pages(mdesc->request, sizeof(struct snp_guest_msg));
iounmap((__force void __iomem *)mdesc->secrets);
- memset(mdesc, 0, sizeof(*mdesc));
- kfree(mdesc);
+ kfree_sensitive(mdesc);
}
EXPORT_SYMBOL_GPL(snp_msg_free);
© 2016 - 2026 Red Hat, Inc.