To manage GENI serial engine resources during runtime power management,
drivers currently need to call functions for ICC, clock, and
SE resource operations in both suspend and resume paths, resulting in
code duplication across drivers.
The new geni_se_resources_activate() and geni_se_resources_deactivate()
helper APIs addresses this issue by providing a streamlined method to
enable or disable all resources based, thereby eliminating redundancy
across drivers.
Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
---
v1->v2:
Bjorn:
- Remove geni_se_resources_state() API.
- Used geni_se_resources_activate() and geni_se_resources_deactivate()
to enable/disable resources.
---
drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++-----------------------
1 file changed, 5 insertions(+), 23 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index a4b13022e508..b0a18e3d57d9 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev)
struct geni_i2c_dev *gi2c = dev_get_drvdata(dev);
disable_irq(gi2c->irq);
- ret = geni_se_resources_off(&gi2c->se);
+
+ ret = geni_se_resources_deactivate(&gi2c->se);
if (ret) {
enable_irq(gi2c->irq);
return ret;
-
- } else {
- gi2c->suspended = 1;
}
- clk_disable_unprepare(gi2c->core_clk);
-
- return geni_icc_disable(&gi2c->se);
+ gi2c->suspended = 1;
+ return ret;
}
static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
@@ -1179,28 +1176,13 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
int ret;
struct geni_i2c_dev *gi2c = dev_get_drvdata(dev);
- ret = geni_icc_enable(&gi2c->se);
+ ret = geni_se_resources_activate(&gi2c->se);
if (ret)
return ret;
- ret = clk_prepare_enable(gi2c->core_clk);
- if (ret)
- goto out_icc_disable;
-
- ret = geni_se_resources_on(&gi2c->se);
- if (ret)
- goto out_clk_disable;
-
enable_irq(gi2c->irq);
gi2c->suspended = 0;
- return 0;
-
-out_clk_disable:
- clk_disable_unprepare(gi2c->core_clk);
-out_icc_disable:
- geni_icc_disable(&gi2c->se);
-
return ret;
}
--
2.34.1On 1/12/26 11:47 AM, Praveen Talari wrote: > To manage GENI serial engine resources during runtime power management, > drivers currently need to call functions for ICC, clock, and > SE resource operations in both suspend and resume paths, resulting in > code duplication across drivers. > > The new geni_se_resources_activate() and geni_se_resources_deactivate() > helper APIs addresses this issue by providing a streamlined method to > enable or disable all resources based, thereby eliminating redundancy > across drivers. > > Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> > --- > v1->v2: > Bjorn: > - Remove geni_se_resources_state() API. > - Used geni_se_resources_activate() and geni_se_resources_deactivate() > to enable/disable resources. > --- > drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- > 1 file changed, 5 insertions(+), 23 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index a4b13022e508..b0a18e3d57d9 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) > struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); > > disable_irq(gi2c->irq); > - ret = geni_se_resources_off(&gi2c->se); > + > + ret = geni_se_resources_deactivate(&gi2c->se); This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state vote, but the other function doesn't have a counterpart to bring it back Konrad
Hi Konrad, On 1/30/2026 5:35 PM, Konrad Dybcio wrote: > On 1/12/26 11:47 AM, Praveen Talari wrote: >> To manage GENI serial engine resources during runtime power management, >> drivers currently need to call functions for ICC, clock, and >> SE resource operations in both suspend and resume paths, resulting in >> code duplication across drivers. >> >> The new geni_se_resources_activate() and geni_se_resources_deactivate() >> helper APIs addresses this issue by providing a streamlined method to >> enable or disable all resources based, thereby eliminating redundancy >> across drivers. >> >> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> >> --- >> v1->v2: >> Bjorn: >> - Remove geni_se_resources_state() API. >> - Used geni_se_resources_activate() and geni_se_resources_deactivate() >> to enable/disable resources. >> --- >> drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- >> 1 file changed, 5 insertions(+), 23 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c >> index a4b13022e508..b0a18e3d57d9 100644 >> --- a/drivers/i2c/busses/i2c-qcom-geni.c >> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >> @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) >> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); >> >> disable_irq(gi2c->irq); >> - ret = geni_se_resources_off(&gi2c->se); >> + >> + ret = geni_se_resources_deactivate(&gi2c->se); > > This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state This does not apply to I²C, since I²C lacks an OPP table, so the callback is only relevant for SPI and UART. All the refactored APIs were added as generic interfaces shared across I²C, SPI, and UART. Thanks, Praveen Talari > vote, but the other function doesn't have a counterpart to bring it back > > Konrad
On 1/30/26 5:48 PM, Praveen Talari wrote: > Hi Konrad, > > On 1/30/2026 5:35 PM, Konrad Dybcio wrote: >> On 1/12/26 11:47 AM, Praveen Talari wrote: >>> To manage GENI serial engine resources during runtime power management, >>> drivers currently need to call functions for ICC, clock, and >>> SE resource operations in both suspend and resume paths, resulting in >>> code duplication across drivers. >>> >>> The new geni_se_resources_activate() and geni_se_resources_deactivate() >>> helper APIs addresses this issue by providing a streamlined method to >>> enable or disable all resources based, thereby eliminating redundancy >>> across drivers. >>> >>> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> >>> --- >>> v1->v2: >>> Bjorn: >>> - Remove geni_se_resources_state() API. >>> - Used geni_se_resources_activate() and geni_se_resources_deactivate() >>> to enable/disable resources. >>> --- >>> drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- >>> 1 file changed, 5 insertions(+), 23 deletions(-) >>> >>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c >>> index a4b13022e508..b0a18e3d57d9 100644 >>> --- a/drivers/i2c/busses/i2c-qcom-geni.c >>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >>> @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) >>> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); >>> disable_irq(gi2c->irq); >>> - ret = geni_se_resources_off(&gi2c->se); >>> + >>> + ret = geni_se_resources_deactivate(&gi2c->se); >> >> This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state > > This does not apply to I²C, since I²C lacks an OPP table, so the callback is only relevant for SPI and UART. All the refactored APIs were added as generic interfaces shared across I²C, SPI, and UART. Does the i2c mode not require any ratesetting on the SE clock, or any >= LOWSVS RPMh vote on the power rail? Konrad
Hi Konrad, On 2/3/2026 4:43 PM, Konrad Dybcio wrote: > On 1/30/26 5:48 PM, Praveen Talari wrote: >> Hi Konrad, >> >> On 1/30/2026 5:35 PM, Konrad Dybcio wrote: >>> On 1/12/26 11:47 AM, Praveen Talari wrote: >>>> To manage GENI serial engine resources during runtime power management, >>>> drivers currently need to call functions for ICC, clock, and >>>> SE resource operations in both suspend and resume paths, resulting in >>>> code duplication across drivers. >>>> >>>> The new geni_se_resources_activate() and geni_se_resources_deactivate() >>>> helper APIs addresses this issue by providing a streamlined method to >>>> enable or disable all resources based, thereby eliminating redundancy >>>> across drivers. >>>> >>>> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> >>>> --- >>>> v1->v2: >>>> Bjorn: >>>> - Remove geni_se_resources_state() API. >>>> - Used geni_se_resources_activate() and geni_se_resources_deactivate() >>>> to enable/disable resources. >>>> --- >>>> drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++----------------------- >>>> 1 file changed, 5 insertions(+), 23 deletions(-) >>>> >>>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c >>>> index a4b13022e508..b0a18e3d57d9 100644 >>>> --- a/drivers/i2c/busses/i2c-qcom-geni.c >>>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >>>> @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev) >>>> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev); >>>> disable_irq(gi2c->irq); >>>> - ret = geni_se_resources_off(&gi2c->se); >>>> + >>>> + ret = geni_se_resources_deactivate(&gi2c->se); >>> >>> This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state >> >> This does not apply to I²C, since I²C lacks an OPP table, so the callback is only relevant for SPI and UART. All the refactored APIs were added as generic interfaces shared across I²C, SPI, and UART. > > Does the i2c mode not require any ratesetting on the SE clock, or Yes, it is not needed since we are updating clock related values in SE register like I2C_SCL_COUNTERS. Thanks, Praveen Talari > any >= LOWSVS RPMh vote on the power rail? > > Konrad
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
On 1/12/2026 4:17 PM, Praveen Talari wrote:
> To manage GENI serial engine resources during runtime power management,
> drivers currently need to call functions for ICC, clock, and
> SE resource operations in both suspend and resume paths, resulting in
> code duplication across drivers.
>
> The new geni_se_resources_activate() and geni_se_resources_deactivate()
> helper APIs addresses this issue by providing a streamlined method to
> enable or disable all resources based, thereby eliminating redundancy
> across drivers.
>
> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
> ---
> v1->v2:
> Bjorn:
> - Remove geni_se_resources_state() API.
> - Used geni_se_resources_activate() and geni_se_resources_deactivate()
> to enable/disable resources.
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 28 +++++-----------------------
> 1 file changed, 5 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index a4b13022e508..b0a18e3d57d9 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -1160,18 +1160,15 @@ static int __maybe_unused geni_i2c_runtime_suspend(struct device *dev)
> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev);
>
> disable_irq(gi2c->irq);
> - ret = geni_se_resources_off(&gi2c->se);
> +
> + ret = geni_se_resources_deactivate(&gi2c->se);
> if (ret) {
> enable_irq(gi2c->irq);
> return ret;
> -
> - } else {
> - gi2c->suspended = 1;
> }
>
> - clk_disable_unprepare(gi2c->core_clk);
> -
> - return geni_icc_disable(&gi2c->se);
> + gi2c->suspended = 1;
> + return ret;
> }
>
> static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
> @@ -1179,28 +1176,13 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev)
> int ret;
> struct geni_i2c_dev *gi2c = dev_get_drvdata(dev);
>
> - ret = geni_icc_enable(&gi2c->se);
> + ret = geni_se_resources_activate(&gi2c->se);
> if (ret)
> return ret;
>
> - ret = clk_prepare_enable(gi2c->core_clk);
> - if (ret)
> - goto out_icc_disable;
> -
> - ret = geni_se_resources_on(&gi2c->se);
> - if (ret)
> - goto out_clk_disable;
> -
> enable_irq(gi2c->irq);
> gi2c->suspended = 0;
>
> - return 0;
> -
> -out_clk_disable:
> - clk_disable_unprepare(gi2c->core_clk);
> -out_icc_disable:
> - geni_icc_disable(&gi2c->se);
> -
> return ret;
> }
>
© 2016 - 2026 Red Hat, Inc.