GPIO pin 102 is related to DisplayPort what is not supported
by this device and it is also disabled at downstream,
remove the unnecessary extcon-usb node.

Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
 arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
index 4c548cb5f253..666daf4a9fdd 100644
--- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
+++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
@@ -80,11 +80,6 @@ ramoops@61600000 {
 		};
 	};
 
-	extcon_usb: extcon-usb {
-		compatible = "linux,extcon-usb-gpio";
-		id-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>;
-	};
-
 	gpio-keys {
 		compatible = "gpio-keys";
 
@@ -307,7 +302,3 @@ &tlmm {
 &usb3 {
 	status = "okay";
 };
-
-&usb3_dwc3 {
-	extcon = <&extcon_usb>;
-};

-- 
2.52.0

On 1/12/26 9:13 PM, Barnabás Czémán wrote:
> GPIO pin 102 is related to DisplayPort what is not supported
> by this device and it is also disabled at downstream,
> remove the unnecessary extcon-usb node.

If you put the phone in fastboot, and connect a USB3-capable type-C
cable (making sure that it's not a fake one, usb3 ones are noticeably
thicker), does it show up as a SuperSpeed device?

Konrad

On 2026-01-13 10:00, Konrad Dybcio wrote:
> On 1/12/26 9:13 PM, Barnabás Czémán wrote:
>> GPIO pin 102 is related to DisplayPort what is not supported
>> by this device and it is also disabled at downstream,
>> remove the unnecessary extcon-usb node.
> 
> If you put the phone in fastboot, and connect a USB3-capable type-C
> cable (making sure that it's not a fake one, usb3 ones are noticeably
> thicker), does it show up as a SuperSpeed device?
No, only high speed is supported, and qmp_phy was changed to nop_phy at 
downstream.
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/arch/arm64/boot/dts/qcom/trinket-usb.dtsi#L99
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/arch/arm64/boot/dts/qcom/trinket-usb.dtsi#L89

> 
> Konrad

On 1/13/26 10:11 AM, barnabas.czeman@mainlining.org wrote:
> On 2026-01-13 10:00, Konrad Dybcio wrote:
>> On 1/12/26 9:13 PM, Barnabás Czémán wrote:
>>> GPIO pin 102 is related to DisplayPort what is not supported
>>> by this device and it is also disabled at downstream,
>>> remove the unnecessary extcon-usb node.
>>
>> If you put the phone in fastboot, and connect a USB3-capable type-C
>> cable (making sure that it's not a fake one, usb3 ones are noticeably
>> thicker), does it show up as a SuperSpeed device?
> No, only high speed is supported, and qmp_phy was changed to nop_phy at downstream.
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/arch/arm64/boot/dts/qcom/trinket-usb.dtsi#L99
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/arch/arm64/boot/dts/qcom/trinket-usb.dtsi#L89

Alright, thanks

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

On 1/12/26 9:13 PM, Barnabás Czémán wrote:
> GPIO pin 102 is related to DisplayPort what is not supported
> by this device and it is also disabled at downstream,
> remove the unnecessary extcon-usb node.
> 
> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> index 4c548cb5f253..666daf4a9fdd 100644
> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
> @@ -80,11 +80,6 @@ ramoops@61600000 {
>  		};
>  	};
>  
> -	extcon_usb: extcon-usb {
> -		compatible = "linux,extcon-usb-gpio";
> -		id-gpios = <&tlmm 102 GPIO_ACTIVE_HIGH>;
> -	};

FWIW

trinket-sde.dtsi (downstream for this SoC):

	qcom,usbplug-cc-gpio = <&tlmm 102 0>;

trinket-pinctrl.dtsi:
	sde_dp_usbplug_cc_active: sde_dp_usbplug_cc_active {
                        mux {
                                pins = "gpio102";
                                function = "gpio"; <---
                        };

                        config {
                                pins = "gpio102";
                                bias-disable;
                                drive-strength = <16>;
                        };
                };
reading the blurb in downstream's gpu/drm/msm/dp/dp_parser.c this
seems to be the select pin of a GPIO Type-C mux?

Konrad

On Mon, Jan 12, 2026 at 09:13:26PM +0100, Barnabás Czémán wrote:
> GPIO pin 102 is related to DisplayPort what is not supported
> by this device and it is also disabled at downstream,
> remove the unnecessary extcon-usb node.
> 
> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
>  arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 9 ---------
>  1 file changed, 9 deletions(-)

Thanks!


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>



-- 
With best wishes
Dmitry