[v2] MIPS: move pic32.h header file from asm to platform_data

[PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h

Posted by Brian Masney 3 weeks, 6 days ago

The linux/io.h include is not used, so let's drop it from pic32.h.

Signed-off-by: Brian Masney <bmasney@redhat.com>

---
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 arch/mips/include/asm/mach-pic32/pic32.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/include/asm/mach-pic32/pic32.h b/arch/mips/include/asm/mach-pic32/pic32.h
index e71c92a7bfde1342be6ea89a4bdf1389aa463b38..660fa4178b3e4e30977c8c4126df4266150062ce 100644
--- a/arch/mips/include/asm/mach-pic32/pic32.h
+++ b/arch/mips/include/asm/mach-pic32/pic32.h
@@ -6,7 +6,6 @@
 #ifndef _ASM_MACH_PIC32_H
 #define _ASM_MACH_PIC32_H
 
-#include <linux/io.h>
 #include <linux/types.h>
 
 /*

-- 
2.52.0

Re: [PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h

Posted by claudiu beznea 3 weeks, 3 days ago

Hi, Brian,

On 1/13/26 00:47, Brian Masney wrote:
> The linux/io.h include is not used, so let's drop it from pic32.h.
> 
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> 
> ---
> To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: linux-mips@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/mips/include/asm/mach-pic32/pic32.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/include/asm/mach-pic32/pic32.h b/arch/mips/include/asm/mach-pic32/pic32.h
> index e71c92a7bfde1342be6ea89a4bdf1389aa463b38..660fa4178b3e4e30977c8c4126df4266150062ce 100644
> --- a/arch/mips/include/asm/mach-pic32/pic32.h
> +++ b/arch/mips/include/asm/mach-pic32/pic32.h
> @@ -6,7 +6,6 @@
>   #ifndef _ASM_MACH_PIC32_H
>   #define _ASM_MACH_PIC32_H
>   
> -#include <linux/io.h>

Can't this be squashed this with patch 02/16 ?

>   #include <linux/types.h>
>   
>   /*
>

Re: [PATCH v2 03/16] MIPS: pic32: drop unused include linux/io.h from pic32.h

Posted by Brian Masney 3 weeks, 3 days ago

On Fri, Jan 16, 2026 at 09:12:45AM +0200, claudiu beznea wrote:
> On 1/13/26 00:47, Brian Masney wrote:
> > The linux/io.h include is not used, so let's drop it from pic32.h.
> > 
> > Signed-off-by: Brian Masney <bmasney@redhat.com>
> > 
> > ---
> > To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: linux-mips@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >   arch/mips/include/asm/mach-pic32/pic32.h | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/arch/mips/include/asm/mach-pic32/pic32.h b/arch/mips/include/asm/mach-pic32/pic32.h
> > index e71c92a7bfde1342be6ea89a4bdf1389aa463b38..660fa4178b3e4e30977c8c4126df4266150062ce 100644
> > --- a/arch/mips/include/asm/mach-pic32/pic32.h
> > +++ b/arch/mips/include/asm/mach-pic32/pic32.h
> > @@ -6,7 +6,6 @@
> >   #ifndef _ASM_MACH_PIC32_H
> >   #define _ASM_MACH_PIC32_H
> > -#include <linux/io.h>
> 
> Can't this be squashed this with patch 02/16 ?

I made it a separate patch because generally if the commit message
listing all of the changes has 'and' then that's maybe a hint that
it should be split out into it's own commit.

That said, if people really want, I can push out a new series with
it squashed.

Brian