patch v2 : apologies, I had missed an __le32 field.

- Use __le32 fields for structures sent/received over USB
 Addresses a comment from when this driver was initially merged:
  https://lore.kernel.org/all/s5hd0agcjw1.wl-tiwai@suse.de/

- Document constants and protocol details common to the Studio 1810 and
1824c devices

Except for a hypothetical big-endian platform (which I cannot test) where the first
commit would make a difference, both these should have no functional
change.

Signed-off-by: fenugrec <fenugrec@mail.com>
---
Changes in v2:
- fix an overlooked __le32 conversion for .tag and .len fields
- Link to v1: https://lore.kernel.org/r/20260110-preso_clean1-v1-0-ce2dd3ea4506@mail.com

---
fenugrec (2):
      ALSA: usb-audio: presonus s18xx uses little-endian
      ALSA: usb-audio: clean up presonus s1810 consts

 sound/usb/mixer_s1810c.c | 224 ++++++++++++++++++++++++++++-------------------
 1 file changed, 134 insertions(+), 90 deletions(-)
---
base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
change-id: 20260110-preso_clean1-162b2bd8bdb9

Best regards,
-- 
fenugrec <fenugrec@mail.com>

On Sun, 11 Jan 2026 22:36:39 +0100,
fenugrec via B4 Relay wrote:
> 
> patch v2 : apologies, I had missed an __le32 field.
> 
> - Use __le32 fields for structures sent/received over USB
>  Addresses a comment from when this driver was initially merged:
>   https://lore.kernel.org/all/s5hd0agcjw1.wl-tiwai@suse.de/
> 
> - Document constants and protocol details common to the Studio 1810 and
> 1824c devices
> 
> Except for a hypothetical big-endian platform (which I cannot test) where the first
> commit would make a difference, both these should have no functional
> change.
> 
> Signed-off-by: fenugrec <fenugrec@mail.com>
> ---
> Changes in v2:
> - fix an overlooked __le32 conversion for .tag and .len fields
> - Link to v1: https://lore.kernel.org/r/20260110-preso_clean1-v1-0-ce2dd3ea4506@mail.com

Thanks for the patches.  The code changes look OK, so I can take as
is.

But I wonder about your identity "fenugrec".  Is it a real name?
The Signed-off-by line needs to be a real name (or a known identity) 
for legal reasons.


thanks,

Takashi

Hi,
 
> The Signed-off-by line needs to be a real name (or a known identity) 
> for legal reasons.

is it acceptable if I've been using this same identity since at least 2009:
https://sourceforge.net/p/freediag/gitrepo/ci/9314daac0cecda4e82b5e3e0de4d75fa62cffe93/ 

I can also PGP-sign (7F91B004A4E206EC) commits or sign-offs if that would be helpful?

Thanks !