[v1] dt-bindings: serial: sh-sci: Fold single-entry compatibles into enum

[PATCH] dt-bindings: serial: sh-sci: Fold single-entry compatibles into enum

Posted by Prabhakar 1 month ago

From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Group single compatibles into enum.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 .../devicetree/bindings/serial/renesas,scif.yaml          | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index 72483bc3274d..d4cdbbf4c1f1 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -20,6 +20,8 @@ properties:
       - items:
           - enum:
               - renesas,scif-r7s9210      # RZ/A2
+              - renesas,scif-r9a07g044    # RZ/G2{L,LC}
+              - renesas,scif-r9a09g057    # RZ/V2H(P)
 
       - items:
           - enum:
@@ -76,10 +78,6 @@ properties:
           - const: renesas,rcar-gen5-scif # R-Car Gen5
           - const: renesas,scif           # generic SCIF compatible UART
 
-      - items:
-          - enum:
-              - renesas,scif-r9a07g044      # RZ/G2{L,LC}
-
       - items:
           - enum:
               - renesas,scif-r9a07g043      # RZ/G2UL and RZ/Five
@@ -87,8 +85,6 @@ properties:
               - renesas,scif-r9a08g045      # RZ/G3S
           - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback
 
-      - const: renesas,scif-r9a09g057       # RZ/V2H(P)
-
       - items:
           - enum:
               - renesas,scif-r9a09g047      # RZ/G3E
-- 
2.52.0

Re: [PATCH] dt-bindings: serial: sh-sci: Fold single-entry compatibles into enum

Posted by Geert Uytterhoeven 1 month ago

Hi Prabhakar,

On Fri, 9 Jan 2026 at 13:38, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Group single compatibles into enum.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -20,6 +20,8 @@ properties:
>        - items:

I the "- items:" can be dropped, reducing indentation of the block
below.

>            - enum:
>                - renesas,scif-r7s9210      # RZ/A2
> +              - renesas,scif-r9a07g044    # RZ/G2{L,LC}
> +              - renesas,scif-r9a09g057    # RZ/V2H(P)

This block now indeed contains all single compatible values, but it
is still located in the middle of other multi-compatible entries.
What about making it the first block in the "oneOf:"?


For the contents:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: serial: sh-sci: Fold single-entry compatibles into enum

Posted by Lad, Prabhakar 1 month ago

Hi Geert,

Thank you for the review.

On Fri, Jan 9, 2026 at 1:28 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, 9 Jan 2026 at 13:38, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Group single compatibles into enum.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -20,6 +20,8 @@ properties:
> >        - items:
>
> I the "- items:" can be dropped, reducing indentation of the block
> below.
>
Agreed.

> >            - enum:
> >                - renesas,scif-r7s9210      # RZ/A2
> > +              - renesas,scif-r9a07g044    # RZ/G2{L,LC}
> > +              - renesas,scif-r9a09g057    # RZ/V2H(P)
>
> This block now indeed contains all single compatible values, but it
> is still located in the middle of other multi-compatible entries.
> What about making it the first block in the "oneOf:"?
>
Ok, I will move it at the top and send a v2.

Cheers,
Prabhakar

>
> For the contents:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds