[PATCH] perf/core: make nr_addr_filters attribute static

Ben Dooks posted 1 patch 4 weeks, 1 day ago
kernel/events/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf/core: make nr_addr_filters attribute static
Posted by Ben Dooks 4 weeks, 1 day ago
The 'dev_attr_nr_addr_filters' attribute is not exported
outside of the kernel/events/core.c file so make it static
to avoid the following sparse warning:

kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?

Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index dad0d3d2e85f..b79f9be8f074 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
 
 	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
 }
-DEVICE_ATTR_RO(nr_addr_filters);
+static DEVICE_ATTR_RO(nr_addr_filters);
 
 static struct idr pmu_idr;
 
-- 
2.37.2.352.g3c44437643
Re: [PATCH] perf/core: make nr_addr_filters attribute static
Posted by Mi, Dapeng 3 weeks, 5 days ago
On 1/9/2026 8:27 PM, Ben Dooks wrote:
> The 'dev_attr_nr_addr_filters' attribute is not exported
> outside of the kernel/events/core.c file so make it static
> to avoid the following sparse warning:
>
> kernel/events/core.c:12170:1: warning: symbol 'dev_attr_nr_addr_filters' was not declared. Should it be static?
>
> Fixes: 6e855cd4f4b52 ("perf/core: Let userspace know if the PMU supports address filters")
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index dad0d3d2e85f..b79f9be8f074 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -12167,7 +12167,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
>  
>  	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
>  }
> -DEVICE_ATTR_RO(nr_addr_filters);
> +static DEVICE_ATTR_RO(nr_addr_filters);
>  
>  static struct idr pmu_idr;
>  

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>