---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 119 +++++------------------
1 file changed, 23 insertions(+), 96 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index db86e2bd0c7b..676f8ecd89e2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1755,22 +1755,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ovl0_in: endpoint@0 {
- reg = <0>;
+ ovl0_in: endpoint {
remote-endpoint = <&mmsys_ep_main>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ovl0_out: endpoint@0 {
- reg = <0>;
+ ovl0_out: endpoint {
remote-endpoint = <&ovl_2l0_in>;
};
};
@@ -1792,22 +1784,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ovl_2l0_in: endpoint@0 {
- reg = <0>;
+ ovl_2l0_in: endpoint {
remote-endpoint = <&ovl0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ovl_2l0_out: endpoint@0 {
- reg = <0>;
+ ovl_2l0_out: endpoint {
remote-endpoint = <&rdma0_in>;
};
};
@@ -1867,22 +1851,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- rdma0_in: endpoint@0 {
- reg = <0>;
+ rdma0_in: endpoint {
remote-endpoint = <&ovl_2l0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- rdma0_out: endpoint@0 {
- reg = <0>;
+ rdma0_out: endpoint {
remote-endpoint = <&color0_in>;
};
};
@@ -1904,9 +1880,9 @@ ports {
#size-cells = <0>;
port@0 {
- reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+ reg = <0>;
rdma1_in: endpoint@1 {
reg = <1>;
@@ -1915,9 +1891,9 @@ rdma1_in: endpoint@1 {
};
port@1 {
- reg = <1>;
#address-cells = <1>;
#size-cells = <0>;
+ reg = <1>;
rdma1_out: endpoint@1 {
reg = <1>;
@@ -1942,22 +1918,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- color0_in: endpoint@0 {
- reg = <0>;
+ color0_in: endpoint {
remote-endpoint = <&rdma0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- color0_out: endpoint@0 {
- reg = <0>;
+ color0_out: endpoint {
remote-endpoint = <&ccorr0_in>;
};
};
@@ -1978,22 +1946,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ccorr0_in: endpoint@0 {
- reg = <0>;
+ ccorr0_in: endpoint {
remote-endpoint = <&color0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- ccorr0_out: endpoint@0 {
- reg = <0>;
+ ccorr0_out: endpoint {
remote-endpoint = <&aal0_in>;
};
};
@@ -2014,22 +1974,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- aal0_in: endpoint@0 {
- reg = <0>;
+ aal0_in: endpoint {
remote-endpoint = <&ccorr0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- aal0_out: endpoint@0 {
- reg = <0>;
+ aal0_out: endpoint {
remote-endpoint = <&gamma0_in>;
};
};
@@ -2050,22 +2002,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- gamma0_in: endpoint@0 {
- reg = <0>;
+ gamma0_in: endpoint {
remote-endpoint = <&aal0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- gamma0_out: endpoint@0 {
- reg = <0>;
+ gamma0_out: endpoint {
remote-endpoint = <&dither0_in>;
};
};
@@ -2086,22 +2030,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- dither0_in: endpoint@0 {
- reg = <0>;
+ dither0_in: endpoint {
remote-endpoint = <&gamma0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- dither0_out: endpoint@0 {
- reg = <0>;
+ dither0_out: endpoint {
remote-endpoint = <&dsi_in>;
};
};
@@ -2128,23 +2064,14 @@ ports {
port@0 {
reg = <0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- dsi_in: endpoint@0 {
- reg = <0>;
+ dsi_in: endpoint {
remote-endpoint = <&dither0_out>;
};
};
port@1 {
reg = <1>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- dsi_out: endpoint@0 {
- reg = <0>;
- };
+ dsi_out: endpoint { };
};
};
};
@@ -2165,9 +2092,9 @@ ports {
#size-cells = <0>;
port@0 {
- reg = <0>;
#address-cells = <1>;
#size-cells = <0>;
+ reg = <0>;
dpi_in: endpoint@1 {
reg = <1>;
@@ -2176,11 +2103,11 @@ dpi_in: endpoint@1 {
};
port@1 {
- reg = <1>;
#address-cells = <1>;
#size-cells = <0>;
+ reg = <1>;
- dpi_out: endpoint@1 {
+ dpi_out: endpoint@1 {
reg = <1>;
};
};
--
2.52.0On Fri, Jan 9, 2026 at 7:48 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
No commit message?
> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 119 +++++------------------
> 1 file changed, 23 insertions(+), 96 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index db86e2bd0c7b..676f8ecd89e2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
[...]
> @@ -1904,9 +1880,9 @@ ports {
> #size-cells = <0>;
>
> port@0 {
> - reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> + reg = <0>;
reg should be first or second (when the first property is "compatible")
property under a node.
Ref: "Order of Properties in Device Node" in
Documentation/devicetree/bindings/dts-coding-style.rst
>
> rdma1_in: endpoint@1 {
> reg = <1>;
> @@ -1915,9 +1891,9 @@ rdma1_in: endpoint@1 {
> };
>
> port@1 {
> - reg = <1>;
> #address-cells = <1>;
> #size-cells = <0>;
> + reg = <1>;
Same here.
>
> rdma1_out: endpoint@1 {
> reg = <1>;
[...]
> @@ -2165,9 +2092,9 @@ ports {
> #size-cells = <0>;
>
> port@0 {
> - reg = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
> + reg = <0>;
>
> dpi_in: endpoint@1 {
> reg = <1>;
> @@ -2176,11 +2103,11 @@ dpi_in: endpoint@1 {
> };
>
> port@1 {
> - reg = <1>;
> #address-cells = <1>;
> #size-cells = <0>;
> + reg = <1>;
>
> - dpi_out: endpoint@1 {
> + dpi_out: endpoint@1 {
> reg = <1>;
> };
> };
Same for these two blocks.
So all the deletions are correct, but the simple reordering is wrong and
not needed.
Once fixed,
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
ChenYu
© 2016 - 2026 Red Hat, Inc.