[PATCH 09/11] arm64: dts: mediatek: mt8173-elm: Remove regulators from thermal node

AngeloGioacchino Del Regno posted 11 patches 1 month ago
[PATCH 09/11] arm64: dts: mediatek: mt8173-elm: Remove regulators from thermal node
Posted by AngeloGioacchino Del Regno 1 month ago
The only reason to have a regulator in the thermal node is to keep
the CPU cores up while reading temperatures, but this is incorrect
because the AUXADC Thermal IP doesn't need any regulators to work,
at all.

Since the thermal node was inherited only for adding vregs, remove
it entirely.
This change is safe also because, among other things, the actual
driver never used those regulators anyway.

This also fixes a dtbs_check warning.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index dc064cdcedb5..a0573bc359fb 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -1147,11 +1147,6 @@ &ssusb {
 	status = "okay";
 };
 
-&thermal {
-	bank0-supply = <&mt6397_vpca15_reg>;
-	bank1-supply = <&da9211_vcpu_reg>;
-};
-
 &uart0 {
 	status = "okay";
 };
-- 
2.52.0
Re: [PATCH 09/11] arm64: dts: mediatek: mt8173-elm: Remove regulators from thermal node
Posted by Chen-Yu Tsai 4 weeks ago
On Fri, Jan 9, 2026 at 7:48 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> The only reason to have a regulator in the thermal node is to keep
> the CPU cores up while reading temperatures, but this is incorrect
> because the AUXADC Thermal IP doesn't need any regulators to work,
> at all.
>
> Since the thermal node was inherited only for adding vregs, remove
> it entirely.
> This change is safe also because, among other things, the actual
> driver never used those regulators anyway.
>
> This also fixes a dtbs_check warning.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>