[PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message

Kunihiko Hayashi posted 1 patch 1 month ago
drivers/net/ethernet/socionext/sni_ave.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
[PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
Posted by Kunihiko Hayashi 1 month ago
Follow the warning from checkpatch.pl and remove 'out of memory' message.

    WARNING: Possible unnecessary 'out of memory' message
    #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
    +               if (!skb) {
    +                       netdev_err(ndev, "can't allocate skb for Rx\n");

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 drivers/net/ethernet/socionext/sni_ave.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c
index 66b3549636f8..4700998c4837 100644
--- a/drivers/net/ethernet/socionext/sni_ave.c
+++ b/drivers/net/ethernet/socionext/sni_ave.c
@@ -586,10 +586,8 @@ static int ave_rxdesc_prepare(struct net_device *ndev, int entry)
 	skb = priv->rx.desc[entry].skbs;
 	if (!skb) {
 		skb = netdev_alloc_skb(ndev, AVE_MAX_ETHFRAME);
-		if (!skb) {
-			netdev_err(ndev, "can't allocate skb for Rx\n");
+		if (!skb)
 			return -ENOMEM;
-		}
 		skb->data += AVE_FRAME_HEADROOM;
 		skb->tail += AVE_FRAME_HEADROOM;
 	}
-- 
2.34.1
Re: [PATCH RESEND net-next v1] net: ethernet: ave: Remove unnecessary 'out of memory' message
Posted by Andrew Lunn 1 month ago
On Fri, Jan 09, 2026 at 07:39:15PM +0900, Kunihiko Hayashi wrote:
> Follow the warning from checkpatch.pl and remove 'out of memory' message.
> 
>     WARNING: Possible unnecessary 'out of memory' message
>     #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
>     +               if (!skb) {
>     +                       netdev_err(ndev, "can't allocate skb for Rx\n");
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew