[PATCH] KVM: arm64: remove unused vcpu_{clear,set}_wfx_traps()

Dongxu Sun posted 1 patch 1 month ago
arch/arm64/include/asm/kvm_emulate.h | 16 ----------------
1 file changed, 16 deletions(-)
[PATCH] KVM: arm64: remove unused vcpu_{clear,set}_wfx_traps()
Posted by Dongxu Sun 1 month ago
Function vcpu_{clear,set}_wfx_traps() are unused since
commit 0b5afe05377d7 ("KVM: arm64: Add early_param to control WFx trapping")
Remove it.

Signed-off-by: Dongxu Sun <sundongxu1024@163.com>
---
 arch/arm64/include/asm/kvm_emulate.h | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/arch/arm64/include/asm/kvm_emulate.h b/arch/arm64/include/asm/kvm_emulate.h
index c9eab316398e..55d34192a8de 100644
--- a/arch/arm64/include/asm/kvm_emulate.h
+++ b/arch/arm64/include/asm/kvm_emulate.h
@@ -119,22 +119,6 @@ static inline unsigned long *vcpu_hcr(struct kvm_vcpu *vcpu)
 	return (unsigned long *)&vcpu->arch.hcr_el2;
 }
 
-static inline void vcpu_clear_wfx_traps(struct kvm_vcpu *vcpu)
-{
-	vcpu->arch.hcr_el2 &= ~HCR_TWE;
-	if (atomic_read(&vcpu->arch.vgic_cpu.vgic_v3.its_vpe.vlpi_count) ||
-	    vcpu->kvm->arch.vgic.nassgireq)
-		vcpu->arch.hcr_el2 &= ~HCR_TWI;
-	else
-		vcpu->arch.hcr_el2 |= HCR_TWI;
-}
-
-static inline void vcpu_set_wfx_traps(struct kvm_vcpu *vcpu)
-{
-	vcpu->arch.hcr_el2 |= HCR_TWE;
-	vcpu->arch.hcr_el2 |= HCR_TWI;
-}
-
 static inline unsigned long vcpu_get_vsesr(struct kvm_vcpu *vcpu)
 {
 	return vcpu->arch.vsesr_el2;
-- 
2.43.0
Re: [PATCH] KVM: arm64: remove unused vcpu_{clear,set}_wfx_traps()
Posted by Zenghui Yu 1 month ago
s/remove/Remove/ in the Subject.

On 2026/1/9 10:58, Dongxu Sun wrote:
> Function vcpu_{clear,set}_wfx_traps() are unused since
> commit 0b5afe05377d7 ("KVM: arm64: Add early_param to control WFx trapping")

checkpatch WARNING: Prefer a maximum 75 chars per line (possible
unwrapped commit description?)

> Remove it.
> 
> Signed-off-by: Dongxu Sun <sundongxu1024@163.com>
> ---
>  arch/arm64/include/asm/kvm_emulate.h | 16 ----------------
>  1 file changed, 16 deletions(-)

Otherwise,

Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>

Thanks,
Zenghui