drivers/staging/fbtft/fb_tinylcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Checkpatch reports a misaligned continuation line in the
fb_tinylcd init_display() write_reg() gamma table. Align the
continuation line with the open parenthesis to match kernel style.
No functional change.
Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2c50..60cda57bcb33 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
--
2.50.1 (Apple Git-155)
Thanks Greg, Agreed. This change does not improve readability, and checkpatch is only a guide. I will drop this patch. Regards, Chaitanya
On Thu, Jan 08, 2026 at 03:17:09PM +0530, Chaitanya Mishra wrote: > Checkpatch reports a misaligned continuation line in the > > fb_tinylcd init_display() write_reg() gamma table. Align the > > continuation line with the open parenthesis to match kernel style. > > No functional change. > > Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com> > --- > drivers/staging/fbtft/fb_tinylcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c > index 9469248f2c50..60cda57bcb33 100644 > --- a/drivers/staging/fbtft/fb_tinylcd.c > +++ b/drivers/staging/fbtft/fb_tinylcd.c > @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par) > write_reg(par, 0xE5, 0x00); > write_reg(par, 0xF0, 0x36, 0xA5, 0x53); > write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00, > - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); > + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00); That kind of makes the code harder to read, right? checkpatch is a guide, always use it as a hint, not as a rule. thanks, greg k-h
© 2016 - 2026 Red Hat, Inc.