rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()

[PATCH] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()

Posted by Randy Dunlap 1 month ago

IS_REACHABLE() is meant to be used with full symbol names from a kernel
.config file, not the shortened symbols used in Kconfig files, so
change HWMON to CONFIG_HWMON in 3 places.

Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org

 drivers/rtc/rtc-max31335.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20260107.orig/drivers/rtc/rtc-max31335.c
+++ linux-next-20260107/drivers/rtc/rtc-max31335.c
@@ -591,7 +591,7 @@ static struct nvmem_config max31335_nvme
 	.size = MAX31335_RAM_SIZE,
 };
 
-#if IS_REACHABLE(HWMON)
+#if IS_REACHABLE(CONFIG_HWMON)
 static int max31335_read_temp(struct device *dev, enum hwmon_sensor_types type,
 			      u32 attr, int channel, long *val)
 {
@@ -672,7 +672,7 @@ static int max31335_clkout_register(stru
 static int max31335_probe(struct i2c_client *client)
 {
 	struct max31335_data *max31335;
-#if IS_REACHABLE(HWMON)
+#if IS_REACHABLE(CONFIG_HWMON)
 	struct device *hwmon;
 #endif
 	const struct chip_desc *match;
@@ -727,7 +727,7 @@ static int max31335_probe(struct i2c_cli
 		return dev_err_probe(&client->dev, ret,
 				     "cannot register rtc nvmem\n");
 
-#if IS_REACHABLE(HWMON)
+#if IS_REACHABLE(CONFIG_HWMON)
 	if (max31335->chip->temp_reg) {
 		hwmon = devm_hwmon_device_register_with_info(&client->dev, client->name, max31335,
 							     &max31335_chip_info, NULL);

Re: [PATCH] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()

Posted by Alexandre Belloni 2 weeks, 5 days ago

On Wed, 07 Jan 2026 20:54:32 -0800, Randy Dunlap wrote:
> IS_REACHABLE() is meant to be used with full symbol names from a kernel
> .config file, not the shortened symbols used in Kconfig files, so
> change HWMON to CONFIG_HWMON in 3 places.
> 
> 

Applied, thanks!

[1/1] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()
      https://git.kernel.org/abelloni/c/d5aca9a17f6d

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] rtc: max31335: use correct CONFIG symbol in IS_REACHABLE()

Posted by Nuno Sá 3 weeks, 5 days ago

On Wed, 2026-01-07 at 20:54 -0800, Randy Dunlap wrote:
> IS_REACHABLE() is meant to be used with full symbol names from a kernel
> .config file, not the shortened symbols used in Kconfig files, so
> change HWMON to CONFIG_HWMON in 3 places.
> 
> Fixes: dedaf03b99d6 ("rtc: max31335: add driver support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---

Acked-by: Nuno Sá <nuno.sa@analog.com>

> Cc: Antoniu Miclaus <antoniu.miclaus@analog.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: linux-rtc@vger.kernel.org
> 
>  drivers/rtc/rtc-max31335.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- linux-next-20260107.orig/drivers/rtc/rtc-max31335.c
> +++ linux-next-20260107/drivers/rtc/rtc-max31335.c
> @@ -591,7 +591,7 @@ static struct nvmem_config max31335_nvme
>  	.size = MAX31335_RAM_SIZE,
>  };
>  
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  static int max31335_read_temp(struct device *dev, enum hwmon_sensor_types type,
>  			      u32 attr, int channel, long *val)
>  {
> @@ -672,7 +672,7 @@ static int max31335_clkout_register(stru
>  static int max31335_probe(struct i2c_client *client)
>  {
>  	struct max31335_data *max31335;
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  	struct device *hwmon;
>  #endif
>  	const struct chip_desc *match;
> @@ -727,7 +727,7 @@ static int max31335_probe(struct i2c_cli
>  		return dev_err_probe(&client->dev, ret,
>  				     "cannot register rtc nvmem\n");
>  
> -#if IS_REACHABLE(HWMON)
> +#if IS_REACHABLE(CONFIG_HWMON)
>  	if (max31335->chip->temp_reg) {
>  		hwmon = devm_hwmon_device_register_with_info(&client->dev, client->name,
> max31335,
>  							     &max31335_chip_info, NULL);