drivers/gpio/Kconfig | 1 - 1 file changed, 1 deletion(-)
MFD_TN48M_CPLD is an undefined Kconfig symbol, so remove its use
in drivers/gpio/Kconfig.
Drop COMPILE_TEST so that the driver can be built at any time.
Fixes: b3dcb5de6209 ("gpio: Add Delta TN48M CPLD GPIO driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Robert Marko <robert.marko@sartura.hr>
Cc: Linus Walleij <linusw@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>
Cc: linux-gpio@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/Kconfig | 1 -
1 file changed, 1 deletion(-)
--- linux-next-20260105.orig/drivers/gpio/Kconfig
+++ linux-next-20260105/drivers/gpio/Kconfig
@@ -1621,7 +1621,6 @@ config GPIO_TIMBERDALE
config GPIO_TN48M_CPLD
tristate "Delta Networks TN48M switch CPLD GPIO driver"
- depends on MFD_TN48M_CPLD || COMPILE_TEST
select GPIO_REGMAP
help
This enables support for the GPIOs found on the Delta
On Thu, Jan 8, 2026 at 4:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> MFD_TN48M_CPLD is an undefined Kconfig symbol, so remove its use
> in drivers/gpio/Kconfig.
> Drop COMPILE_TEST so that the driver can be built at any time.
>
> Fixes: b3dcb5de6209 ("gpio: Add Delta TN48M CPLD GPIO driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Robert Marko <robert.marko@sartura.hr>
> Cc: Linus Walleij <linusw@kernel.org>
> Cc: Bartosz Golaszewski <brgl@kernel.org>
> Cc: linux-gpio@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> drivers/gpio/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-next-20260105.orig/drivers/gpio/Kconfig
> +++ linux-next-20260105/drivers/gpio/Kconfig
> @@ -1621,7 +1621,6 @@ config GPIO_TIMBERDALE
>
> config GPIO_TN48M_CPLD
> tristate "Delta Networks TN48M switch CPLD GPIO driver"
> - depends on MFD_TN48M_CPLD || COMPILE_TEST
> select GPIO_REGMAP
> help
> This enables support for the GPIOs found on the Delta
I see the core MFD part of this driver was reverted by commit
540e6a8114d0 ("Revert "mfd: simple-mfd-i2c: Add Delta TN48M CPLD
support"") years ago. Should this driver even be in the kernel? It
seems to be useless without the parent driver that supplies the
regmap?
I'm asking, because with your change, it will pop up in people's make
config and I've been yelled at before for displaying useless options
so I'm hesitant to make it visible for everyone.
Bart
On 1/8/26 1:04 AM, Bartosz Golaszewski wrote:
> On Thu, Jan 8, 2026 at 4:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> MFD_TN48M_CPLD is an undefined Kconfig symbol, so remove its use
>> in drivers/gpio/Kconfig.
>> Drop COMPILE_TEST so that the driver can be built at any time.
>>
>> Fixes: b3dcb5de6209 ("gpio: Add Delta TN48M CPLD GPIO driver")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> ---
>> Cc: Robert Marko <robert.marko@sartura.hr>
>> Cc: Linus Walleij <linusw@kernel.org>
>> Cc: Bartosz Golaszewski <brgl@kernel.org>
>> Cc: linux-gpio@vger.kernel.org
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> drivers/gpio/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-next-20260105.orig/drivers/gpio/Kconfig
>> +++ linux-next-20260105/drivers/gpio/Kconfig
>> @@ -1621,7 +1621,6 @@ config GPIO_TIMBERDALE
>>
>> config GPIO_TN48M_CPLD
>> tristate "Delta Networks TN48M switch CPLD GPIO driver"
>> - depends on MFD_TN48M_CPLD || COMPILE_TEST
>> select GPIO_REGMAP
>> help
>> This enables support for the GPIOs found on the Delta
>
> I see the core MFD part of this driver was reverted by commit
> 540e6a8114d0 ("Revert "mfd: simple-mfd-i2c: Add Delta TN48M CPLD
> support"") years ago. Should this driver even be in the kernel? It
> seems to be useless without the parent driver that supplies the
> regmap?
>
> I'm asking, because with your change, it will pop up in people's make
> config and I've been yelled at before for displaying useless options
> so I'm hesitant to make it visible for everyone.
I'll send a patch to remove it.
Thanks.
--
~Randy
On Thu, Jan 8, 2026 at 10:04 AM Bartosz Golaszewski <brgl@kernel.org> wrote:
>
> On Thu, Jan 8, 2026 at 4:42 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > MFD_TN48M_CPLD is an undefined Kconfig symbol, so remove its use
> > in drivers/gpio/Kconfig.
> > Drop COMPILE_TEST so that the driver can be built at any time.
> >
> > Fixes: b3dcb5de6209 ("gpio: Add Delta TN48M CPLD GPIO driver")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > ---
> > Cc: Robert Marko <robert.marko@sartura.hr>
> > Cc: Linus Walleij <linusw@kernel.org>
> > Cc: Bartosz Golaszewski <brgl@kernel.org>
> > Cc: linux-gpio@vger.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > drivers/gpio/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > --- linux-next-20260105.orig/drivers/gpio/Kconfig
> > +++ linux-next-20260105/drivers/gpio/Kconfig
> > @@ -1621,7 +1621,6 @@ config GPIO_TIMBERDALE
> >
> > config GPIO_TN48M_CPLD
> > tristate "Delta Networks TN48M switch CPLD GPIO driver"
> > - depends on MFD_TN48M_CPLD || COMPILE_TEST
> > select GPIO_REGMAP
> > help
> > This enables support for the GPIOs found on the Delta
>
> I see the core MFD part of this driver was reverted by commit
> 540e6a8114d0 ("Revert "mfd: simple-mfd-i2c: Add Delta TN48M CPLD
> support"") years ago. Should this driver even be in the kernel? It
> seems to be useless without the parent driver that supplies the
> regmap?
All of the TN48M related drivers are useless without the simple-mfd parent.
Regards,
Robert
>
> I'm asking, because with your change, it will pop up in people's make
> config and I've been yelled at before for displaying useless options
> so I'm hesitant to make it visible for everyone.
>
> Bart
--
Robert Marko
Staff Embedded Linux Engineer
Sartura d.d.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr
© 2016 - 2026 Red Hat, Inc.