[PATCH v5 17/24] scsi: ufs: mediatek: Add vendor prefix to clk-scale-up-vcore-min

Nicolas Frattaroli posted 24 patches 1 month ago
There is a newer version of this series
[PATCH v5 17/24] scsi: ufs: mediatek: Add vendor prefix to clk-scale-up-vcore-min
Posted by Nicolas Frattaroli 1 month ago
Device Tree properties other than the standard properties must be
prefixed with the vendor's name. The "clk-scale-up-vcore-min" property,
which this driver uses, and the binding did not previously document,
lacked a vendor prefix.

Add the missing "mediatek," vendor prefix and clean up the error print.
No judgements are made regarding the use the property itself, it may
turn out to be implementing something that it should do through a
different way (e.g. OPPs).

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
 drivers/ufs/host/ufs-mediatek.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index ecf16e82a326..2b7def2cde54 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -958,9 +958,9 @@ static void ufs_mtk_init_clocks(struct ufs_hba *hba)
 		return;
 	}
 
-	if (of_property_read_u32(dev->of_node, "clk-scale-up-vcore-min",
+	if (of_property_read_u32(dev->of_node, "mediatek,clk-scale-up-vcore-min",
 				 &volt)) {
-		dev_info(dev, "failed to get clk-scale-up-vcore-min");
+		dev_err(dev, "Failed to get mediatek,clk-scale-up-vcore-min\n");
 		return;
 	}
 

-- 
2.52.0
Re: [PATCH v5 17/24] scsi: ufs: mediatek: Add vendor prefix to clk-scale-up-vcore-min
Posted by Krzysztof Kozlowski 1 month ago
On 08/01/2026 11:49, Nicolas Frattaroli wrote:
> Device Tree properties other than the standard properties must be
> prefixed with the vendor's name. The "clk-scale-up-vcore-min" property,
> which this driver uses, and the binding did not previously document,
> lacked a vendor prefix.
> 
> Add the missing "mediatek," vendor prefix and clean up the error print.

Sorry, but no, because it is still undocumented. You cannot add new
undocumented API (at least according to git grep and first three patches
here).

Please instead drop the property completely. Mediatek is not allowed to
push downstream code here.

Best regards,
Krzysztof