[PATCH 02/10] dt-bindings: mtd: fixed-partitions: Move "compression" to partition node

Rob Herring (Arm) posted 10 patches 1 month ago
There is a newer version of this series
[PATCH 02/10] dt-bindings: mtd: fixed-partitions: Move "compression" to partition node
Posted by Rob Herring (Arm) 1 month ago
The "compression" property is defined in the wrong place as it applies
to individual partitions nodes, not all nodes.

Fixes: 8baba8d52ff5 ("dt-bindings: mtd: fixed-partitions: Add compression property")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/mtd/partitions/fixed-partitions.yaml      | 18 ------------------
 .../devicetree/bindings/mtd/partitions/partition.yaml  | 18 ++++++++++++++++++
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
index 62086366837c..73d74c0f5cb7 100644
--- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
+++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
@@ -29,24 +29,6 @@ properties:
 
   "#size-cells": true
 
-  compression:
-    $ref: /schemas/types.yaml#/definitions/string
-    description: |
-      Compression algorithm used to store the data in this partition, chosen
-      from a list of well-known algorithms.
-
-      The contents are compressed using this algorithm.
-
-    enum:
-      - none
-      - bzip2
-      - gzip
-      - lzop
-      - lz4
-      - lzma
-      - xz
-      - zstd
-
 patternProperties:
   "@[0-9a-f]+$":
     $ref: partition.yaml#
diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
index 80d0452a2a33..0b989037a005 100644
--- a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
+++ b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
@@ -108,6 +108,24 @@ properties:
       with the padding bytes, so may grow. If ‘align-end’ is not provided,
       no alignment is performed.
 
+  compression:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: |
+      Compression algorithm used to store the data in this partition, chosen
+      from a list of well-known algorithms.
+
+      The contents are compressed using this algorithm.
+
+    enum:
+      - none
+      - bzip2
+      - gzip
+      - lzop
+      - lz4
+      - lzma
+      - xz
+      - zstd
+
 if:
   not:
     required: [ reg ]

-- 
2.51.0

Re: [PATCH 02/10] dt-bindings: mtd: fixed-partitions: Move "compression" to partition node
Posted by Simon Glass 1 month ago
On Thu, 8 Jan 2026 at 10:53, Rob Herring (Arm) <robh@kernel.org> wrote:
>
> The "compression" property is defined in the wrong place as it applies
> to individual partitions nodes, not all nodes.
>
> Fixes: 8baba8d52ff5 ("dt-bindings: mtd: fixed-partitions: Add compression property")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/mtd/partitions/fixed-partitions.yaml      | 18 ------------------
>  .../devicetree/bindings/mtd/partitions/partition.yaml  | 18 ++++++++++++++++++
>  2 files changed, 18 insertions(+), 18 deletions(-)
>

Reviewed-by: Simon Glass <simon.glass@canonical.com>


> diff --git a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> index 62086366837c..73d74c0f5cb7 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/fixed-partitions.yaml
> @@ -29,24 +29,6 @@ properties:
>
>    "#size-cells": true
>
> -  compression:
> -    $ref: /schemas/types.yaml#/definitions/string
> -    description: |
> -      Compression algorithm used to store the data in this partition, chosen
> -      from a list of well-known algorithms.
> -
> -      The contents are compressed using this algorithm.
> -
> -    enum:
> -      - none
> -      - bzip2
> -      - gzip
> -      - lzop
> -      - lz4
> -      - lzma
> -      - xz
> -      - zstd
> -
>  patternProperties:
>    "@[0-9a-f]+$":
>      $ref: partition.yaml#
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> index 80d0452a2a33..0b989037a005 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/partition.yaml
> @@ -108,6 +108,24 @@ properties:
>        with the padding bytes, so may grow. If ‘align-end’ is not provided,
>        no alignment is performed.
>
> +  compression:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description: |
> +      Compression algorithm used to store the data in this partition, chosen
> +      from a list of well-known algorithms.
> +
> +      The contents are compressed using this algorithm.
> +
> +    enum:
> +      - none
> +      - bzip2
> +      - gzip
> +      - lzop
> +      - lz4
> +      - lzma
> +      - xz
> +      - zstd
> +
>  if:
>    not:
>      required: [ reg ]
>
> --
> 2.51.0
>
Re: [PATCH 02/10] dt-bindings: mtd: fixed-partitions: Move "compression" to partition node
Posted by Krzysztof Kozlowski 1 month ago
On Thu, Jan 08, 2026 at 11:53:11AM -0600, Rob Herring (Arm) wrote:
> The "compression" property is defined in the wrong place as it applies
> to individual partitions nodes, not all nodes.
> 
> Fixes: 8baba8d52ff5 ("dt-bindings: mtd: fixed-partitions: Add compression property")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  .../bindings/mtd/partitions/fixed-partitions.yaml      | 18 ------------------
>  .../devicetree/bindings/mtd/partitions/partition.yaml  | 18 ++++++++++++++++++
>  2 files changed, 18 insertions(+), 18 deletions(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof