[PATCH 2/3] arm64: dts: apple: t8103: Mark ATC USB AON domains as always-on

Janne Grunau posted 3 patches 1 month ago
[PATCH 2/3] arm64: dts: apple: t8103: Mark ATC USB AON domains as always-on
Posted by Janne Grunau 1 month ago
From: Hector Martin <marcan@marcan.st>

Shutting these down breaks dwc3 init done by the firmware. We probably
never want to do this anyway. It might be possible remove this once
a PHY driver is in place to do the init properly, but it may not be
worth it. "always-on" is a plausible interpretation of the "aon" suffix.
The t8112, t600x and t602x "ps_atc?_usb_aon" power-controller nodes are
have already "apple,always-on" properties.

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Janne Grunau <j@jannau.net>
---
 arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
index c41c57d63997a59a9fe3c88de31fddb31781398e..4bfe0d2de30ad6f975b31d443b62ef0e74b14324 100644
--- a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
+++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi
@@ -1103,6 +1103,7 @@ ps_atc0_usb_aon: power-controller@88 {
 		#power-domain-cells = <0>;
 		#reset-cells = <0>;
 		label = "atc0_usb_aon";
+		apple,always-on; /* Needs to stay on for dwc3 to work */
 	};
 
 	ps_atc1_usb_aon: power-controller@90 {
@@ -1111,6 +1112,7 @@ ps_atc1_usb_aon: power-controller@90 {
 		#power-domain-cells = <0>;
 		#reset-cells = <0>;
 		label = "atc1_usb_aon";
+		apple,always-on; /* Needs to stay on for dwc3 to work */
 	};
 
 	ps_atc0_usb: power-controller@98 {

-- 
2.52.0
Re: [PATCH 2/3] arm64: dts: apple: t8103: Mark ATC USB AON domains as always-on
Posted by Sven Peter 1 month ago

On 1/8/26 22:04, Janne Grunau wrote:
> From: Hector Martin <marcan@marcan.st>
>
> Shutting these down breaks dwc3 init done by the firmware. We probably
> never want to do this anyway. It might be possible remove this once
> a PHY driver is in place to do the init properly, but it may not be
> worth it.
Even with that PHY driver now in place we still need this. No need to 
resend to fix the commit description, I can do that when applying the 
series.


Sven