[v5] clk: amlogic: Add A5 SoC PLLs and Peripheral clock

[PATCH v5 6/8] arm64: dts: amlogic: A5: Add scmi-clk node

Posted by Chuan Liu via B4 Relay 1 month ago

From: Chuan Liu <chuan.liu@amlogic.com>

Add scmi-clk device node information for the Amlogic A5 SoC family.

Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
 arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi | 30 +++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi
index 2b12d8284594..a6625508893d 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi
@@ -7,6 +7,8 @@
 #include "amlogic-a5-reset.h"
 #include <dt-bindings/pinctrl/amlogic,pinctrl.h>
 #include <dt-bindings/power/amlogic,a5-pwrc.h>
+#include <dt-bindings/clock/amlogic,a5-scmi-clkc.h>
+
 / {
 	cpus {
 		#address-cells = <2>;
@@ -49,6 +51,34 @@ pwrc: power-controller {
 			#power-domain-cells = <1>;
 		};
 	};
+
+	sram0: sram@f702a000 {
+		compatible = "mmio-sram";
+		reg = <0x0 0xf702a000 0x0 0x100>;
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0 0x0 0xf702a000 0x100>;
+
+		scmi_buf0: scmi-sram-section@0 {
+			compatible = "arm,scmi-shmem";
+			reg = <0x0 0x100>;
+		};
+	};
+
+	firmware {
+		scmi {
+			compatible = "arm,scmi-smc";
+			arm,smc-id = <0x820000C1>;
+			shmem = <&scmi_buf0>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			scmi_clk: protocol@14 {
+				reg = <0x14>;
+				#clock-cells = <1>;
+			};
+		};
+	};
 };
 
 &apb {

-- 
2.42.0

Re: [PATCH v5 6/8] arm64: dts: amlogic: A5: Add scmi-clk node

Posted by Martin Blumenstingl 4 weeks ago

Hi,

thanks for your patch!

On Thu, Jan 8, 2026 at 7:08 AM Chuan Liu via B4 Relay
<devnull+chuan.liu.amlogic.com@kernel.org> wrote:
[...]
> +       firmware {
> +               scmi {
> +                       compatible = "arm,scmi-smc";
> +                       arm,smc-id = <0x820000C1>;
Just before your v5 Neil merged a patch to use lowercase hex consistently: [0]
Please update this here as well.


Thank you!
Martin


[0] https://git.kernel.org/amlogic/c/7bcbedd64ecf5624583140faebfdb0e2e2f6b43e

Re: [PATCH v5 6/8] arm64: dts: amlogic: A5: Add scmi-clk node

Posted by Chuan Liu 3 weeks, 6 days ago

Hi Martin,

On 1/11/2026 6:08 AM, Martin Blumenstingl wrote:
> [ EXTERNAL EMAIL ]
> 
> Hi,
> 
> thanks for your patch!
> 
> On Thu, Jan 8, 2026 at 7:08 AM Chuan Liu via B4 Relay
> <devnull+chuan.liu.amlogic.com@kernel.org> wrote:
> [...]
>> +       firmware {
>> +               scmi {
>> +                       compatible = "arm,scmi-smc";
>> +                       arm,smc-id = <0x820000C1>;
> Just before your v5 Neil merged a patch to use lowercase hex consistently: [0]
> Please update this here as well.
> 

Thanks for the correction, I'll fix it in the next version.

> 
> Thank you!
> Martin
> 
> 
> [0] https://git.kernel.org/amlogic/c/7bcbedd64ecf5624583140faebfdb0e2e2f6b43e