Add the devicetree binding documentation for the Andes ATCWDT200
watchdog timer, including supported properties and usage examples.

Signed-off-by: CL Wang <cl634@andestech.com>
---
 .../watchdog/andestech,ae350-wdt.yaml         | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
new file mode 100644
index 000000000000..4726bd6734d8
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/andestech,ae350-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Andes ATCWDT200 Watchdog Timer
+
+maintainers:
+  - CL Wang <cl634@andestech.com>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - andestech,qilai-wdt
+          - const: andestech,ae350-wdt
+      - const: andestech,ae350-wdt
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  andestech,clock-source:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - andestech,clock-source
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    watchdog@f0500000 {
+        compatible = "andestech,ae350-wdt";
+        reg = <0xf0500000 0x20>;
+        clocks = <&clk_wdt>;
+        andestech,clock-source = <0>;
+    };
-- 
2.34.1

On Wed, 07 Jan 2026 22:50:55 +0800, CL Wang wrote:
> Add the devicetree binding documentation for the Andes ATCWDT200
> watchdog timer, including supported properties and usage examples.
> 
> Signed-off-by: CL Wang <cl634@andestech.com>
> ---
>  .../watchdog/andestech,ae350-wdt.yaml         | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml: andestech,clock-source: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260107145058.213334-2-cl634@andestech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Hi Rob,

Thanks for the report.

You are right, the andestech,clock-source property is missing a type definition.
I will fix the schema, re-run make dt_binding_check with an up-to-date
dt-schema, and resend the patch.

Best regards,
CL Wang

On 07/01/2026 15:50, CL Wang wrote:
> Add the devicetree binding documentation for the Andes ATCWDT200
> watchdog timer, including supported properties and usage examples.

Last part is redundant. Can you add a binding without supported
properties and without usage examples?

> 
> Signed-off-by: CL Wang <cl634@andestech.com>
> ---
>  .../watchdog/andestech,ae350-wdt.yaml         | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> new file mode 100644
> index 000000000000..4726bd6734d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/andestech,ae350-wdt.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/andestech,ae350-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Andes ATCWDT200 Watchdog Timer
> +
> +maintainers:
> +  - CL Wang <cl634@andestech.com>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - andestech,qilai-wdt
> +          - const: andestech,ae350-wdt
> +      - const: andestech,ae350-wdt

Subject says WDT200, this code sais 350 and qilai. What is what? You
have entire commit msg to explain that
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  andestech,clock-source:

No clue what's this, but for sure does not pass tests without
description and type.

> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - andestech,clock-source
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    watchdog@f0500000 {
> +        compatible = "andestech,ae350-wdt";
> +        reg = <0xf0500000 0x20>;
> +        clocks = <&clk_wdt>;
> +        andestech,clock-source = <0>;
> +    };


Best regards,
Krzysztof

Hi Krzysztof,

Thanks for your review.

On 07/01/2026 15:50, Krzysztof Kozlowski wrote:
> Last part is redundant. Can you add a binding without supported properties and without usage examples?

Agreed. I will remove the redundant part "including supported properties
and usage examples" in the commit message in the next version.

> Subject says WDT200, this code sais 350 and qilai. What is what? You have entire commit msg to explain that

I will clarify in the commit message that ATCWDT200 is the IP name, which
is embedded in AndesCore-based platforms or SoCs such as AE350 and Qilai.

> No clue what's this, but for sure does not pass tests without description and type.

You are right, I missed the type definition. I will add the description
and set the type to uint32 (enum [0, 1]) for `andestech,clock-source`.

Best regards,
CL Wang