[PATCH v2 RESEND 0/3] media: atomisp: refactoring and fixes for V4L2 compliance

Karthikey D Kadati posted 3 patches 1 month ago
There is a newer version of this series
.../media/atomisp/include/linux/atomisp.h     |  19 +--
.../staging/media/atomisp/pci/atomisp_cmd.c   | 142 +++++++++---------
.../staging/media/atomisp/pci/atomisp_ioctl.c | 123 +++++++++------
.../staging/media/atomisp/pci/ia_css_types.h  |   6 +-
.../staging/media/atomisp/pci/sh_css_params.c |  16 +-
5 files changed, 166 insertions(+), 140 deletions(-)
[PATCH v2 RESEND 0/3] media: atomisp: refactoring and fixes for V4L2 compliance
Posted by Karthikey D Kadati 1 month ago
This patch series addresses maintainer feedback and fixes build errors
in the atomisp driver.

Patch 1: Standardizes the 'Bridge' structs significantly by using v4l2_rect instead of custom shadow structs and aligning ia_css_region members with V4L2 conventions.
Patch 2: Introduces a helper function for statistics buffer allocation to reduce code duplication and centralize error handling logic.
Patch 3: Adds missing error propagation for IRQ enable and XNR configuration to improve robustness.

This series is based on the latest staging/next tree and has been verified with checkpatch.pl --strict.

Karthikey D Kadati (3):
  media: atomisp: replace shadow zoom structs with v4l2_rect
  media: atomisp: consolidate statistics buffer allocation
  media: atomisp: propagate errors from ISP xnr and IRQ enable

 .../media/atomisp/include/linux/atomisp.h     |  19 +--
 .../staging/media/atomisp/pci/atomisp_cmd.c   | 142 +++++++++---------
 .../staging/media/atomisp/pci/atomisp_ioctl.c | 123 +++++++++------
 .../staging/media/atomisp/pci/ia_css_types.h  |   6 +-
 .../staging/media/atomisp/pci/sh_css_params.c |  16 +-
 5 files changed, 166 insertions(+), 140 deletions(-)

-- 
2.43.0
Re: [PATCH v2 RESEND 0/3] media: atomisp: refactoring and fixes for V4L2 compliance
Posted by Dan Carpenter 1 month ago
When you're sending v2, it's better to just start a new thread.  We stopped
sending them as a reply years ago.  It makes threads too confusing.

On Wed, Jan 07, 2026 at 07:18:41PM +0530, Karthikey D Kadati wrote:
> This patch series addresses maintainer feedback and fixes build errors
> in the atomisp driver.
> 
> Patch 1: Standardizes the 'Bridge' structs significantly by using v4l2_rect instead of custom shadow structs and aligning ia_css_region members with V4L2 conventions.
> Patch 2: Introduces a helper function for statistics buffer allocation to reduce code duplication and centralize error handling logic.
> Patch 3: Adds missing error propagation for IRQ enable and XNR configuration to improve robustness.
> 

Please line wrap your emails at 72 characters.

regards,
dan carpenter