[PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate

A. Sverdlin posted 2 patches 1 month ago
There is a newer version of this series
[PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate
Posted by A. Sverdlin 1 month ago
From: Alexander Sverdlin <alexander.sverdlin@siemens.com>

Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
properties. The properties are only applicable for ports in R(G)MII mode
and allow for slew rate reduction in comparison to "normal" default
configuration with the purpose to reduce radiated emissions.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
---
Changelog:
v4:
- separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
v3:
- use [pinctrl] standard "slew-rate" property as suggested by Rob
  https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
v2:
- unchanged

 .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
index 205b683849a53..747106810cc17 100644
--- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
@@ -106,6 +106,20 @@ patternProperties:
         unevaluatedProperties: false
 
         properties:
+          maxlinear,slew-rate-txc:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum: [0, 1]
+            description: |
+              RMII/RGMII TX Clock Slew Rate:
+              0: "Normal"
+              1: "Slow"
+          maxlinear,slew-rate-txd:
+            $ref: /schemas/types.yaml#/definitions/uint32
+            enum: [0, 1]
+            description: |
+              RMII/RGMII TX Non-Clock PAD Slew Rate:
+              0: "Normal"
+              1: "Slow"
           maxlinear,rmii-refclk-out:
             type: boolean
             description:
-- 
2.52.0
Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate
Posted by Rob Herring 3 weeks, 6 days ago
On Wed, Jan 07, 2026 at 10:00:16AM +0100, A. Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
> properties. The properties are only applicable for ports in R(G)MII mode
> and allow for slew rate reduction in comparison to "normal" default
> configuration with the purpose to reduce radiated emissions.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> ---
> Changelog:
> v4:
> - separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
> v3:
> - use [pinctrl] standard "slew-rate" property as suggested by Rob
>   https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
> v2:
> - unchanged
> 
>  .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index 205b683849a53..747106810cc17 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -106,6 +106,20 @@ patternProperties:
>          unevaluatedProperties: false
>  
>          properties:
> +          maxlinear,slew-rate-txc:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            enum: [0, 1]

default: 0

> +            description: |
> +              RMII/RGMII TX Clock Slew Rate:

blank line
> +              0: "Normal"
> +              1: "Slow"

Indent lists by 2 more spaces. Drop the quotes.

> +          maxlinear,slew-rate-txd:
> +            $ref: /schemas/types.yaml#/definitions/uint32
> +            enum: [0, 1]
> +            description: |
> +              RMII/RGMII TX Non-Clock PAD Slew Rate:
> +              0: "Normal"
> +              1: "Slow"
>            maxlinear,rmii-refclk-out:
>              type: boolean
>              description:
> -- 
> 2.52.0
>
Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate
Posted by Daniel Golle 3 weeks, 6 days ago
On Tue, Jan 13, 2026 at 10:41:28AM -0600, Rob Herring wrote:
> On Wed, Jan 07, 2026 at 10:00:16AM +0100, A. Sverdlin wrote:
> > From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> > 
> > Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
> > properties. The properties are only applicable for ports in R(G)MII mode
> > and allow for slew rate reduction in comparison to "normal" default
> > configuration with the purpose to reduce radiated emissions.
> > 
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> > ---
> > Changelog:
> > v4:
> > - separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
> > v3:
> > - use [pinctrl] standard "slew-rate" property as suggested by Rob
> >   https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
> > v2:
> > - unchanged
> > 
> >  .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > index 205b683849a53..747106810cc17 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > @@ -106,6 +106,20 @@ patternProperties:
> >          unevaluatedProperties: false
> >  
> >          properties:
> > +          maxlinear,slew-rate-txc:
> > +            $ref: /schemas/types.yaml#/definitions/uint32
> > +            enum: [0, 1]
> 
> default: 0

Not really. The default is not to touch the register value which may
have already been setup by the bootloader.

> 
> > +            description: |
> > +              RMII/RGMII TX Clock Slew Rate:
> 
> blank line
> > +              0: "Normal"
> > +              1: "Slow"
> 
> Indent lists by 2 more spaces. Drop the quotes.
> 
> > +          maxlinear,slew-rate-txd:
> > +            $ref: /schemas/types.yaml#/definitions/uint32
> > +            enum: [0, 1]
> > +            description: |
> > +              RMII/RGMII TX Non-Clock PAD Slew Rate:
> > +              0: "Normal"
> > +              1: "Slow"
> >            maxlinear,rmii-refclk-out:
> >              type: boolean
> >              description:
> > -- 
> > 2.52.0
> >
Re: [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add MaxLinear R(G)MII slew rate
Posted by Rob Herring 3 weeks, 5 days ago
On Tue, Jan 13, 2026 at 10:59 AM Daniel Golle <daniel@makrotopia.org> wrote:
>
> On Tue, Jan 13, 2026 at 10:41:28AM -0600, Rob Herring wrote:
> > On Wed, Jan 07, 2026 at 10:00:16AM +0100, A. Sverdlin wrote:
> > > From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> > >
> > > Add new maxlinear,slew-rate-txc and maxlinear,slew-rate-txd uint32
> > > properties. The properties are only applicable for ports in R(G)MII mode
> > > and allow for slew rate reduction in comparison to "normal" default
> > > configuration with the purpose to reduce radiated emissions.
> > >
> > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> > > ---
> > > Changelog:
> > > v4:
> > > - separate properties for TXD and TXC pads ("maxlinear," prefix re-appears)
> > > v3:
> > > - use [pinctrl] standard "slew-rate" property as suggested by Rob
> > >   https://lore.kernel.org/all/20251219204324.GA3881969-robh@kernel.org/
> > > v2:
> > > - unchanged
> > >
> > >  .../devicetree/bindings/net/dsa/lantiq,gswip.yaml  | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > > index 205b683849a53..747106810cc17 100644
> > > --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > > +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> > > @@ -106,6 +106,20 @@ patternProperties:
> > >          unevaluatedProperties: false
> > >
> > >          properties:
> > > +          maxlinear,slew-rate-txc:
> > > +            $ref: /schemas/types.yaml#/definitions/uint32
> > > +            enum: [0, 1]
> >
> > default: 0
>
> Not really. The default is not to touch the register value which may
> have already been setup by the bootloader.

Okay, please add that to the description.

Rob