drivers/iio/adc/ad7476.c | 1 - 1 file changed, 1 deletion(-)
Remove duplicate inclusion of linux/bitops.h.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/iio/adc/ad7476.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c
index 1bec6657394c..21d3f6aae972 100644
--- a/drivers/iio/adc/ad7476.c
+++ b/drivers/iio/adc/ad7476.c
@@ -16,7 +16,6 @@
#include <linux/gpio/consumer.h>
#include <linux/err.h>
#include <linux/module.h>
-#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/iio/iio.h>
--
2.25.1
On 07/01/2026 10:29, Chen Ni wrote: > Remove duplicate inclusion of linux/bitops.h. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> I would also appreciate having the includes alphabetically ordered as Andy suggested. This, however, is a fine fix as it is so: Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com> > --- > drivers/iio/adc/ad7476.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c > index 1bec6657394c..21d3f6aae972 100644 > --- a/drivers/iio/adc/ad7476.c > +++ b/drivers/iio/adc/ad7476.c > @@ -16,7 +16,6 @@ > #include <linux/gpio/consumer.h> > #include <linux/err.h> > #include <linux/module.h> > -#include <linux/bitops.h> > #include <linux/delay.h> > > #include <linux/iio/iio.h> -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~
On Thu, 8 Jan 2026 08:06:13 +0200 Matti Vaittinen <mazziesaccount@gmail.com> wrote: > On 07/01/2026 10:29, Chen Ni wrote: > > Remove duplicate inclusion of linux/bitops.h. > > > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > > I would also appreciate having the includes alphabetically ordered as > Andy suggested. This, however, is a fine fix as it is so: > > Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com> Applied this one. As Andy observes in v2 review the first patch should be this anyway! Thanks, Jonathan > > > --- > > drivers/iio/adc/ad7476.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/iio/adc/ad7476.c b/drivers/iio/adc/ad7476.c > > index 1bec6657394c..21d3f6aae972 100644 > > --- a/drivers/iio/adc/ad7476.c > > +++ b/drivers/iio/adc/ad7476.c > > @@ -16,7 +16,6 @@ > > #include <linux/gpio/consumer.h> > > #include <linux/err.h> > > #include <linux/module.h> > > -#include <linux/bitops.h> > > #include <linux/delay.h> > > > > #include <linux/iio/iio.h> > >
On Wed, Jan 07, 2026 at 04:29:20PM +0800, Chen Ni wrote: > Remove duplicate inclusion of linux/bitops.h. ... > --- a/drivers/iio/adc/ad7476.c > +++ b/drivers/iio/adc/ad7476.c > #include <linux/gpio/consumer.h> > #include <linux/err.h> > #include <linux/module.h> > -#include <linux/bitops.h> > #include <linux/delay.h> Can you actually sort the headers alphabetically so this will be visible change (in terms of the context)? -- With Best Regards, Andy Shevchenko
© 2016 - 2026 Red Hat, Inc.