drivers/net/usb/usbnet.c | 2 ++ 1 file changed, 2 insertions(+)
From: Zqiang <qiang.zhang@linux.dev>
Syzbot reported the following warning:
BUG: using smp_processor_id() in preemptible [00000000] code: dhcpcd/2879
caller is usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
CPU: 1 UID: 0 PID: 2879 Comm: dhcpcd Not tainted 6.15.0-rc4-syzkaller-00098-g615dca38c2ea #0 PREEMPT(voluntary)
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x16c/0x1f0 lib/dump_stack.c:120
check_preemption_disabled+0xd0/0xe0 lib/smp_processor_id.c:49
usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
usbnet_resume_rx+0x4b/0x170 drivers/net/usb/usbnet.c:708
usbnet_change_mtu+0x1be/0x220 drivers/net/usb/usbnet.c:417
__dev_set_mtu net/core/dev.c:9443 [inline]
netif_set_mtu_ext+0x369/0x5c0 net/core/dev.c:9496
netif_set_mtu+0xb0/0x160 net/core/dev.c:9520
dev_set_mtu+0xae/0x170 net/core/dev_api.c:247
dev_ifsioc+0xa31/0x18d0 net/core/dev_ioctl.c:572
dev_ioctl+0x223/0x10e0 net/core/dev_ioctl.c:821
sock_do_ioctl+0x19d/0x280 net/socket.c:1204
sock_ioctl+0x42f/0x6a0 net/socket.c:1311
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:906 [inline]
__se_sys_ioctl fs/ioctl.c:892 [inline]
__x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
entry_SYSCALL_64_after_hwframe+0x77/0x7f
For historical and portability reasons, the netif_rx() is usually
run in the softirq or interrupt context, this commit therefore add
local_bh_disable/enable() protection in the usbnet_resume_rx().
Fixes: 43daa96b166c ("usbnet: Stop RX Q on MTU change")
Link: https://syzkaller.appspot.com/bug?id=81f55dfa587ee544baaaa5a359a060512228c1e1
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Link: https://patch.msgid.link/20251011070518.7095-1-qiang.zhang@linux.dev
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
[ The context change is due to the commit 2c04d279e857
("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
in v6.17 which is irrelevant to the logic of this patch.]
Signed-off-by: Rahul Sharma <black.hawk@163.com>
---
drivers/net/usb/usbnet.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 0ff7357c3c91..f1f61d85d949 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -702,6 +702,7 @@ void usbnet_resume_rx(struct usbnet *dev)
struct sk_buff *skb;
int num = 0;
+ local_bh_disable();
clear_bit(EVENT_RX_PAUSED, &dev->flags);
while ((skb = skb_dequeue(&dev->rxq_pause)) != NULL) {
@@ -710,6 +711,7 @@ void usbnet_resume_rx(struct usbnet *dev)
}
tasklet_schedule(&dev->bh);
+ local_bh_enable();
netif_dbg(dev, rx_status, dev->net,
"paused rx queue disabled, %d skbs requeued\n", num);
--
2.34.1Hi Rahul,
On 07/01/26 13:48, Rahul Sharma wrote:
> From: Zqiang <qiang.zhang@linux.dev>
>
> Syzbot reported the following warning:
>
> BUG: using smp_processor_id() in preemptible [00000000] code: dhcpcd/2879
> caller is usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
> CPU: 1 UID: 0 PID: 2879 Comm: dhcpcd Not tainted 6.15.0-rc4-syzkaller-00098-g615dca38c2ea #0 PREEMPT(voluntary)
> Call Trace:
> <TASK>
> __dump_stack lib/dump_stack.c:94 [inline]
> dump_stack_lvl+0x16c/0x1f0 lib/dump_stack.c:120
> check_preemption_disabled+0xd0/0xe0 lib/smp_processor_id.c:49
> usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
> usbnet_resume_rx+0x4b/0x170 drivers/net/usb/usbnet.c:708
> usbnet_change_mtu+0x1be/0x220 drivers/net/usb/usbnet.c:417
> __dev_set_mtu net/core/dev.c:9443 [inline]
> netif_set_mtu_ext+0x369/0x5c0 net/core/dev.c:9496
> netif_set_mtu+0xb0/0x160 net/core/dev.c:9520
> dev_set_mtu+0xae/0x170 net/core/dev_api.c:247
> dev_ifsioc+0xa31/0x18d0 net/core/dev_ioctl.c:572
> dev_ioctl+0x223/0x10e0 net/core/dev_ioctl.c:821
> sock_do_ioctl+0x19d/0x280 net/socket.c:1204
> sock_ioctl+0x42f/0x6a0 net/socket.c:1311
> vfs_ioctl fs/ioctl.c:51 [inline]
> __do_sys_ioctl fs/ioctl.c:906 [inline]
> __se_sys_ioctl fs/ioctl.c:892 [inline]
> __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
> do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> For historical and portability reasons, the netif_rx() is usually
> run in the softirq or interrupt context, this commit therefore add
> local_bh_disable/enable() protection in the usbnet_resume_rx().
>
> Fixes: 43daa96b166c ("usbnet: Stop RX Q on MTU change")
> Link: https://syzkaller.appspot.com/bug?id=81f55dfa587ee544baaaa5a359a060512228c1e1
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> Link: https://patch.msgid.link/20251011070518.7095-1-qiang.zhang@linux.dev
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> [ The context change is due to the commit 2c04d279e857
> ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
> in v6.17 which is irrelevant to the logic of this patch.]
> Signed-off-by: Rahul Sharma <black.hawk@163.com>
> ---
Greg already queued this for 6.12.64:
https://lore.kernel.org/all/20260106170510.964268694@linuxfoundation.org/
and 6.12.64 is now released. So I think we can skip this patch.
Also, if you want to figure this out without searching on lore. You
could use stable-queue repo to see if a patch you are trying to backport
is already being backported by someone else.
stable-queue repo:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/
Thanks,
Harshit
On Wed, Jan 07, 2026 at 04:18:55PM +0800, Rahul Sharma wrote:
> From: Zqiang <qiang.zhang@linux.dev>
>
> Syzbot reported the following warning:
>
> BUG: using smp_processor_id() in preemptible [00000000] code: dhcpcd/2879
> caller is usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
> CPU: 1 UID: 0 PID: 2879 Comm: dhcpcd Not tainted 6.15.0-rc4-syzkaller-00098-g615dca38c2ea #0 PREEMPT(voluntary)
> Call Trace:
> <TASK>
> __dump_stack lib/dump_stack.c:94 [inline]
> dump_stack_lvl+0x16c/0x1f0 lib/dump_stack.c:120
> check_preemption_disabled+0xd0/0xe0 lib/smp_processor_id.c:49
> usbnet_skb_return+0x74/0x490 drivers/net/usb/usbnet.c:331
> usbnet_resume_rx+0x4b/0x170 drivers/net/usb/usbnet.c:708
> usbnet_change_mtu+0x1be/0x220 drivers/net/usb/usbnet.c:417
> __dev_set_mtu net/core/dev.c:9443 [inline]
> netif_set_mtu_ext+0x369/0x5c0 net/core/dev.c:9496
> netif_set_mtu+0xb0/0x160 net/core/dev.c:9520
> dev_set_mtu+0xae/0x170 net/core/dev_api.c:247
> dev_ifsioc+0xa31/0x18d0 net/core/dev_ioctl.c:572
> dev_ioctl+0x223/0x10e0 net/core/dev_ioctl.c:821
> sock_do_ioctl+0x19d/0x280 net/socket.c:1204
> sock_ioctl+0x42f/0x6a0 net/socket.c:1311
> vfs_ioctl fs/ioctl.c:51 [inline]
> __do_sys_ioctl fs/ioctl.c:906 [inline]
> __se_sys_ioctl fs/ioctl.c:892 [inline]
> __x64_sys_ioctl+0x190/0x200 fs/ioctl.c:892
> do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
> do_syscall_64+0xcd/0x260 arch/x86/entry/syscall_64.c:94
> entry_SYSCALL_64_after_hwframe+0x77/0x7f
>
> For historical and portability reasons, the netif_rx() is usually
> run in the softirq or interrupt context, this commit therefore add
> local_bh_disable/enable() protection in the usbnet_resume_rx().
>
> Fixes: 43daa96b166c ("usbnet: Stop RX Q on MTU change")
> Link: https://syzkaller.appspot.com/bug?id=81f55dfa587ee544baaaa5a359a060512228c1e1
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
> Link: https://patch.msgid.link/20251011070518.7095-1-qiang.zhang@linux.dev
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> [ The context change is due to the commit 2c04d279e857
> ("net: usb: Convert tasklet API to new bottom half workqueue mechanism")
> in v6.17 which is irrelevant to the logic of this patch.]
> Signed-off-by: Rahul Sharma <black.hawk@163.com>
> ---
> drivers/net/usb/usbnet.c | 2 ++
> 1 file changed, 2 insertions(+)
What is the git id of this commit in Linus's tree?
thanks,
greg k-h
© 2016 - 2026 Red Hat, Inc.