sound/hda/common/hda_jack.h | 4 ++-- sound/hda/common/hda_local.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Use the correct function names and add a function parameter description
to avoid kernel-doc warnings:
hda_jack.h:97: warning: Function parameter or struct member 'cb' not
described in 'snd_hda_jack_detect_enable_callback'
hda_jack.h:97: warning: expecting prototype for snd_hda_jack_detect_enable().
Prototype was for snd_hda_jack_detect_enable_callback() instead
hda_local.h:441: warning: expecting prototype for _snd_hda_set_pin_ctl().
Prototype was for snd_hda_set_pin_ctl() instead
Fixes: cdd03cedc5b5 ("ALSA: hda - Introduce snd_hda_set_pin_ctl*() helper functions")
Fixes: 5204a05d70d9 ("ALSA: hda - Add DP-MST jack support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org
Cc: Nikhil Mahale <nmahale@nvidia.com>
sound/hda/common/hda_jack.h | 4 ++--
sound/hda/common/hda_local.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20260105.orig/sound/hda/common/hda_jack.h
+++ linux-next-20260105/sound/hda/common/hda_jack.h
@@ -82,10 +82,10 @@ snd_hda_jack_detect_enable_callback_mst(
int dev_id, hda_jack_callback_fn func);
/**
- * snd_hda_jack_detect_enable - enable the jack-detection
+ * snd_hda_jack_detect_enable_callback - enable the jack-detection
* @codec: the HDA codec
* @nid: pin NID to enable
- * @func: callback function to register
+ * @cb: callback function to register
*
* In the case of error, the return value will be a pointer embedded with
* errno. Check and handle the return value appropriately with standard
--- linux-next-20260105.orig/sound/hda/common/hda_local.h
+++ linux-next-20260105/sound/hda/common/hda_local.h
@@ -424,7 +424,7 @@ int _snd_hda_set_pin_ctl(struct hda_code
unsigned int val, bool cached);
/**
- * _snd_hda_set_pin_ctl - Set a pin-control value safely
+ * snd_hda_set_pin_ctl - Set a pin-control value safely
* @codec: the codec instance
* @pin: the pin NID to set the control
* @val: the pin-control value (AC_PINCTL_* bits)
On Tue, 06 Jan 2026 19:59:51 +0100,
Randy Dunlap wrote:
>
> Use the correct function names and add a function parameter description
> to avoid kernel-doc warnings:
>
> hda_jack.h:97: warning: Function parameter or struct member 'cb' not
> described in 'snd_hda_jack_detect_enable_callback'
> hda_jack.h:97: warning: expecting prototype for snd_hda_jack_detect_enable().
> Prototype was for snd_hda_jack_detect_enable_callback() instead
> hda_local.h:441: warning: expecting prototype for _snd_hda_set_pin_ctl().
> Prototype was for snd_hda_set_pin_ctl() instead
>
> Fixes: cdd03cedc5b5 ("ALSA: hda - Introduce snd_hda_set_pin_ctl*() helper functions")
> Fixes: 5204a05d70d9 ("ALSA: hda - Add DP-MST jack support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied to for-next branch now. Thanks.
Takashi
© 2016 - 2026 Red Hat, Inc.