iio: bmi270_i2c: Add MODULE_DEVICE_TABLE for BMI260/270

[PATCH] iio: bmi270_i2c: Add MODULE_DEVICE_TABLE for BMI260/270

Posted by Derek J. Clark 1 month ago

Currently BMI260 & BMI270 devices do not automatically load this
driver. To fix this, add missing MODULE_DEVICE_TABLE for the i2c,
acpi, and of device tables so the driver will load when the hardware
is detected.

Tested on my OneXPlayer F1 Pro.

Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
---
 drivers/iio/imu/bmi270/bmi270_i2c.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
index b909a421ad01..b92da4e0776f 100644
--- a/drivers/iio/imu/bmi270/bmi270_i2c.c
+++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
@@ -37,6 +37,7 @@ static const struct i2c_device_id bmi270_i2c_id[] = {
 	{ "bmi270", (kernel_ulong_t)&bmi270_chip_info },
 	{ }
 };
+MODULE_DEVICE_TABLE(i2c, bmi270_i2c_id);
 
 static const struct acpi_device_id bmi270_acpi_match[] = {
 	/* GPD Win Mini, Aya Neo AIR Pro, OXP Mini Pro, etc. */
@@ -45,12 +46,14 @@ static const struct acpi_device_id bmi270_acpi_match[] = {
 	{ "BMI0260",  (kernel_ulong_t)&bmi260_chip_info },
 	{ }
 };
+MODULE_DEVICE_TABLE(acpi, bmi270_acpi_match);
 
 static const struct of_device_id bmi270_of_match[] = {
 	{ .compatible = "bosch,bmi260", .data = &bmi260_chip_info },
 	{ .compatible = "bosch,bmi270", .data = &bmi270_chip_info },
 	{ }
 };
+MODULE_DEVICE_TABLE(of, bmi270_of_match);
 
 static struct i2c_driver bmi270_i2c_driver = {
 	.driver = {
-- 
2.51.2

Re: [PATCH] iio: bmi270_i2c: Add MODULE_DEVICE_TABLE for BMI260/270

Posted by Andy Shevchenko 1 month ago

On Tue, Jan 06, 2026 at 05:45:19AM +0000, Derek J. Clark wrote:
> Currently BMI260 & BMI270 devices do not automatically load this
> driver. To fix this, add missing MODULE_DEVICE_TABLE for the i2c,
> acpi, and of device tables so the driver will load when the hardware
> is detected.
> 
> Tested on my OneXPlayer F1 Pro.

No objections,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] iio: bmi270_i2c: Add MODULE_DEVICE_TABLE for BMI260/270

Posted by Jonathan Cameron 3 weeks, 6 days ago

On Wed, 7 Jan 2026 23:04:53 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Jan 06, 2026 at 05:45:19AM +0000, Derek J. Clark wrote:
> > Currently BMI260 & BMI270 devices do not automatically load this
> > driver. To fix this, add missing MODULE_DEVICE_TABLE for the i2c,
> > acpi, and of device tables so the driver will load when the hardware
> > is detected.
> > 
> > Tested on my OneXPlayer F1 Pro.  
> 
> No objections,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 
Applied to the togreg branch of iio.git and pushed out as testing.

These are always a bit of a corner case wrt to whether we should treat
them as a fix.  It never worked though so I'm not going to rush them in.
If you want it applied to stable kernels, I'm fine with a request for
that after the next merge window.

Thanks,

Jonathan