Add the sm6150 CCI device string compatible.
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
---
.../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..cb5e6fd5b2ad1de79a9b29d54869d093c952d778 100644
--- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
+++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
@@ -33,6 +33,7 @@ properties:
- qcom,sc8280xp-cci
- qcom,sdm670-cci
- qcom,sdm845-cci
+ - qcom,sm6150-cci
- qcom,sm6350-cci
- qcom,sm8250-cci
- qcom,sm8450-cci
@@ -263,6 +264,23 @@ allOf:
- const: cpas_ahb
- const: cci
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm6150-cci
+ then:
+ properties:
+ clocks:
+ minItems: 3
+ maxItems: 3
+ clock-names:
+ items:
+ - const: soc_ahb
+ - const: cpas_ahb
+ - const: cci
+
additionalProperties: false
examples:
--
2.34.1On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm6150-cci > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + items: > + - const: soc_ahb Same question as before. I did not see any resolution of this in changelog or commit msg. > + - const: cpas_ahb > + - const: cci > + Best regards, Krzysztof
On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote: > On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote: >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sm6150-cci >> + then: >> + properties: >> + clocks: >> + minItems: 3 >> + maxItems: 3 >> + clock-names: >> + items: >> + - const: soc_ahb > > Same question as before. I did not see any resolution of this in > changelog or commit msg. > Will update commit msg in next version: For this platform, it uses soc_ahb instead of camnoc_axi. How about this? Thanks, Wenmeng
On 07/01/2026 09:17, Wenmeng Liu wrote: > > > On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote: >> On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,sm6150-cci >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 3 >>> + maxItems: 3 >>> + clock-names: >>> + items: >>> + - const: soc_ahb >> >> Same question as before. I did not see any resolution of this in >> changelog or commit msg. >> > Will update commit msg in next version: > > For this platform, it uses soc_ahb instead of camnoc_axi. That was not my question from v1. AHB and AXI are both bus clocks, meaning for this device the same. You again name the clocks how you called them in clock controller which is wrong. You name here CLOCK INPUTS. What is the role of this clock FOR THIS DEVICE? I already asked to pay attention to this difference. Best regards, Krzysztof
On 1/7/2026 4:34 PM, Krzysztof Kozlowski wrote: > On 07/01/2026 09:17, Wenmeng Liu wrote: >> >> >> On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote: >>> On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote: >>>> + - if: >>>> + properties: >>>> + compatible: >>>> + contains: >>>> + enum: >>>> + - qcom,sm6150-cci >>>> + then: >>>> + properties: >>>> + clocks: >>>> + minItems: 3 >>>> + maxItems: 3 >>>> + clock-names: >>>> + items: >>>> + - const: soc_ahb >>> >>> Same question as before. I did not see any resolution of this in >>> changelog or commit msg. >>> >> Will update commit msg in next version: >> >> For this platform, it uses soc_ahb instead of camnoc_axi. > > That was not my question from v1. AHB and AXI are both bus clocks, > meaning for this device the same. You again name the clocks how you > called them in clock controller which is wrong. You name here CLOCK > INPUTS. What is the role of this clock FOR THIS DEVICE? > > I already asked to pay attention to this difference. > > Best regards, > Krzysztof Ok, i got it, just feel a bit confused. + clocks = <&camcc CAM_CC_SOC_AHB_CLK>, + <&camcc CAM_CC_CPAS_AHB_CLK>, + <&camcc CAM_CC_CCI_CLK>; + clock-names = "camnoc_axi", + "cpas_ahb", + "cci"; clocks = <&camcc CAM_CC_SOC_AHB_CLK>, clock-names = "camnoc_axi"; If this is acceptable, I will update it this way in the next version. Thanks, Wenmeng
On Wed, Jan 7, 2026 at 11:08 AM Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> wrote: > > > > On 1/7/2026 4:34 PM, Krzysztof Kozlowski wrote: > > On 07/01/2026 09:17, Wenmeng Liu wrote: > >> > >> > >> On 1/7/2026 4:00 PM, Krzysztof Kozlowski wrote: > >>> On Tue, Jan 06, 2026 at 05:39:53PM +0800, Wenmeng Liu wrote: > >>>> + - if: > >>>> + properties: > >>>> + compatible: > >>>> + contains: > >>>> + enum: > >>>> + - qcom,sm6150-cci > >>>> + then: > >>>> + properties: > >>>> + clocks: > >>>> + minItems: 3 > >>>> + maxItems: 3 > >>>> + clock-names: > >>>> + items: > >>>> + - const: soc_ahb > >>> > >>> Same question as before. I did not see any resolution of this in > >>> changelog or commit msg. > >>> > >> Will update commit msg in next version: > >> > >> For this platform, it uses soc_ahb instead of camnoc_axi. > > > > That was not my question from v1. AHB and AXI are both bus clocks, > > meaning for this device the same. You again name the clocks how you > > called them in clock controller which is wrong. You name here CLOCK > > INPUTS. What is the role of this clock FOR THIS DEVICE? > > > > I already asked to pay attention to this difference. > > > > Best regards, > > Krzysztof > > Ok, i got it, just feel a bit confused. > > + clocks = <&camcc CAM_CC_SOC_AHB_CLK>, > + <&camcc CAM_CC_CPAS_AHB_CLK>, > + <&camcc CAM_CC_CCI_CLK>; > + clock-names = "camnoc_axi", > + "cpas_ahb", > + "cci"; > > > clocks = <&camcc CAM_CC_SOC_AHB_CLK>, > clock-names = "camnoc_axi"; > > If this is acceptable, I will update it this way in the next version. No, the idea is to name the clock from the device’s perspective. For example, from the CCI perspective, you typically have: - A core clock, clocking the logic, which could be named 'core' (but 'cci' here is ok) - Clocks related to the bus interfaces (such as AHB or AXI), which could be named 'iface...' or 'bus...'. This approach clearly identifies the role of each clock and keeps naming consistent, without depending on where the clock originates or its source name. From that standpoint, some of the existing bus clock names defined in qcom,i2c-cci.yaml are not ideal. You can find better naming in bindings like qcom,i2c-qup.yaml or qcom,i2c-geni-qcom.yaml. Regards, Loic
On 1/6/26 11:39, Wenmeng Liu wrote: > Add the sm6150 CCI device string compatible. > > Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com> > --- > .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > index a3fe1eea6aece9685674feaa5ec53765c1ce23d8..cb5e6fd5b2ad1de79a9b29d54869d093c952d778 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml > @@ -33,6 +33,7 @@ properties: > - qcom,sc8280xp-cci > - qcom,sdm670-cci > - qcom,sdm845-cci > + - qcom,sm6150-cci > - qcom,sm6350-cci > - qcom,sm8250-cci > - qcom,sm8450-cci > @@ -263,6 +264,23 @@ allOf: > - const: cpas_ahb > - const: cci > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sm6150-cci > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + items: > + - const: soc_ahb > + - const: cpas_ahb > + - const: cci > + > additionalProperties: false > > examples: > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
© 2016 - 2026 Red Hat, Inc.