1. Patchew
  2. linux
  3. View series

[PATCH] perf build: Raise minimum shellcheck version to 0.7.2

Nicolas Schier posted 1 patch 1 month ago
There is a newer version of this series
tools/perf/Makefile.perf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf build: Raise minimum shellcheck version to 0.7.2
Posted by Nicolas Schier 1 month ago 
Raise the minimum shellcheck version for perf builds to 0.7.2, so that
systems with shellcheck versions below 0.7.2 will automatically skip the
shell script checking, even if NO_SHELLCHECK is unset.

Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
paths"), shellcheck versions before 0.7.2 break the perf build with
several SC1090 [2] warnings due to its too strict dynamic source
handling [1].

Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
Link: https://www.shellcheck.net/wiki/SC1090
Signed-off-by: Nicolas Schier <n.schier@avm.de>
---
This is an alternative to introducing several shellcheck directives to
let old shellcheck versions handle the dynamic source statements
correctly:
https://lore.kernel.org/lkml/20260106-perf-add-shellcheck-sc1090-annotation-v2-1-bd52dc47369e@avm.de/
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index b3f481a626afa314632876449a11eb79b2978824..e2d668fb7f439befd6d1d9cbf66765f8b815e3c6 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -255,7 +255,7 @@ endif
 # minimal shellcheck version as v0.6.0.
 ifneq ($(SHELLCHECK),)
   ifeq ($(shell expr $(shell $(SHELLCHECK) --version | grep version: | \
-        sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 060), 1)
+        sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 072), 1)
     SHELLCHECK :=
   else
     SHELLCHECK := $(SHELLCHECK) -s bash -a -S warning

---
base-commit: 9ace4753a5202b02191d54e9fdf7f9e3d02b85eb
change-id: 20260106-perf-raise-minimum-shellcheck-version-5d684fe90a39

Best regards,
-- 
Nicolas Schier
Re: [PATCH] perf build: Raise minimum shellcheck version to 0.7.2
Posted by Namhyung Kim 1 month ago 
On Tue, Jan 06, 2026 at 02:19:28PM +0100, Nicolas Schier wrote:
> Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> systems with shellcheck versions below 0.7.2 will automatically skip the
> shell script checking, even if NO_SHELLCHECK is unset.
> 
> Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> paths"), shellcheck versions before 0.7.2 break the perf build with
> several SC1090 [2] warnings due to its too strict dynamic source
> handling [1].

It'd be nice if you could copy the error message here.

> 
> Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
> Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
> Link: https://www.shellcheck.net/wiki/SC1090
> Signed-off-by: Nicolas Schier <n.schier@avm.de>

Other than that,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
> This is an alternative to introducing several shellcheck directives to
> let old shellcheck versions handle the dynamic source statements
> correctly:
> https://lore.kernel.org/lkml/20260106-perf-add-shellcheck-sc1090-annotation-v2-1-bd52dc47369e@avm.de/
> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index b3f481a626afa314632876449a11eb79b2978824..e2d668fb7f439befd6d1d9cbf66765f8b815e3c6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -255,7 +255,7 @@ endif
>  # minimal shellcheck version as v0.6.0.
>  ifneq ($(SHELLCHECK),)
>    ifeq ($(shell expr $(shell $(SHELLCHECK) --version | grep version: | \
> -        sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 060), 1)
> +        sed -e 's/.\+ \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \< 072), 1)
>      SHELLCHECK :=
>    else
>      SHELLCHECK := $(SHELLCHECK) -s bash -a -S warning
> 
> ---
> base-commit: 9ace4753a5202b02191d54e9fdf7f9e3d02b85eb
> change-id: 20260106-perf-raise-minimum-shellcheck-version-5d684fe90a39
> 
> Best regards,
> -- 
> Nicolas Schier
>
Re: [PATCH] perf build: Raise minimum shellcheck version to 0.7.2
Posted by Nicolas Schier 1 month ago 
On Tue, Jan 06, 2026 at 11:36:59PM -0800, Namhyung Kim wrote:
> On Tue, Jan 06, 2026 at 02:19:28PM +0100, Nicolas Schier wrote:
> > Raise the minimum shellcheck version for perf builds to 0.7.2, so that
> > systems with shellcheck versions below 0.7.2 will automatically skip the
> > shell script checking, even if NO_SHELLCHECK is unset.
> > 
> > Since commit 241f21be7d0f ("perf test perftool_testsuite: Use absolute
> > paths"), shellcheck versions before 0.7.2 break the perf build with
> > several SC1090 [2] warnings due to its too strict dynamic source
> > handling [1].
> 
> It'd be nice if you could copy the error message here.

Sure.  I'll send v2 with one of the messages included here.

> > 
> > Fixes: 241f21be7d0f ("perf test perftool_testsuite: Use absolute paths")
> > Link: https://github.com/koalaman/shellcheck/issues/1998 # [1]
> > Link: https://www.shellcheck.net/wiki/SC1090
> > Signed-off-by: Nicolas Schier <n.schier@avm.de>
> 
> Other than that,
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks.

Kind regards,
Nicolas

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.