[PATCH v2 09/11] dmaengine: fsl_raid: Simplify with scoped for each OF child loop

Krzysztof Kozlowski posted 11 patches 1 month ago
There is a newer version of this series
[PATCH v2 09/11] dmaengine: fsl_raid: Simplify with scoped for each OF child loop
Posted by Krzysztof Kozlowski 1 month ago
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

Depends on the first patch.
---
 drivers/dma/fsl_raid.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index 6aa97e258a55..6e6d7e0e475e 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -746,7 +746,6 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
 static int fsl_re_probe(struct platform_device *ofdev)
 {
 	struct fsl_re_drv_private *re_priv;
-	struct device_node *np;
 	struct device_node *child;
 	u32 off;
 	u8 ridx = 0;
@@ -823,11 +822,10 @@ static int fsl_re_probe(struct platform_device *ofdev)
 	dev_set_drvdata(dev, re_priv);
 
 	/* Parse Device tree to find out the total number of JQs present */
-	for_each_compatible_node(np, NULL, "fsl,raideng-v1.0-job-queue") {
+	for_each_compatible_node_scoped(np, NULL, "fsl,raideng-v1.0-job-queue") {
 		rc = of_property_read_u32(np, "reg", &off);
 		if (rc) {
 			dev_err(dev, "Reg property not found in JQ node\n");
-			of_node_put(np);
 			return -ENODEV;
 		}
 		/* Find out the Job Rings present under each JQ */

-- 
2.51.0
Re: [PATCH v2 09/11] dmaengine: fsl_raid: Simplify with scoped for each OF child loop
Posted by Vinod Koul 1 month ago
On 06-01-26, 10:15, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.

Acked-by: Vinod Koul <vkoul@kernel.org>


-- 
~Vinod
Re: [PATCH v2 09/11] dmaengine: fsl_raid: Simplify with scoped for each OF child loop
Posted by Frank Li 1 month ago
On Tue, Jan 06, 2026 at 10:15:19AM +0100, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> ---
>
> Depends on the first patch.
> ---
>  drivers/dma/fsl_raid.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
> index 6aa97e258a55..6e6d7e0e475e 100644
> --- a/drivers/dma/fsl_raid.c
> +++ b/drivers/dma/fsl_raid.c
> @@ -746,7 +746,6 @@ static int fsl_re_chan_probe(struct platform_device *ofdev,
>  static int fsl_re_probe(struct platform_device *ofdev)
>  {
>  	struct fsl_re_drv_private *re_priv;
> -	struct device_node *np;
>  	struct device_node *child;
>  	u32 off;
>  	u8 ridx = 0;
> @@ -823,11 +822,10 @@ static int fsl_re_probe(struct platform_device *ofdev)
>  	dev_set_drvdata(dev, re_priv);
>
>  	/* Parse Device tree to find out the total number of JQs present */
> -	for_each_compatible_node(np, NULL, "fsl,raideng-v1.0-job-queue") {
> +	for_each_compatible_node_scoped(np, NULL, "fsl,raideng-v1.0-job-queue") {
>  		rc = of_property_read_u32(np, "reg", &off);
>  		if (rc) {
>  			dev_err(dev, "Reg property not found in JQ node\n");
> -			of_node_put(np);
>  			return -ENODEV;
>  		}
>  		/* Find out the Job Rings present under each JQ */
>
> --
> 2.51.0
>