[PATCH net-next v2] net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()

Yeounsu Moon posted 1 patch 1 month ago
drivers/net/ethernet/dlink/dl2k.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
[PATCH net-next v2] net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()
Posted by Yeounsu Moon 1 month ago
Replace rio_probe1() printk(KERN_INFO) messages with netdev_{info,dbg}().

Keep one netdev_info() line for device identification; move the rest to
netdev_dbg() to avoid spamming the kernel log.

Log rx_timeout on a separate line since netdev_*() prefixes each
message and the multi-line formatting looks broken otherwise.

No functional change intended.

Tested-on: D-Link DGE-550T Rev-A3
Signed-off-by: Yeounsu Moon <yyyynoom@gmail.com>
---
Changelog:
v2:
- Keep one netdev_inf() line; switch the rest to netdev_dbg()
v1: https://lore.kernel.org/netdev/20260104111849.10790-2-yyyynoom@gmail.com/
---
 drivers/net/ethernet/dlink/dl2k.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c
index 846d58c769ea..69bfb8265d57 100644
--- a/drivers/net/ethernet/dlink/dl2k.c
+++ b/drivers/net/ethernet/dlink/dl2k.c
@@ -279,18 +279,15 @@ rio_probe1 (struct pci_dev *pdev, const struct pci_device_id *ent)
 
 	card_idx++;
 
-	printk (KERN_INFO "%s: %s, %pM, IRQ %d\n",
-		dev->name, np->name, dev->dev_addr, irq);
+	netdev_info(dev, "%s, %pM, IRQ %d", np->name, dev->dev_addr, irq);
 	if (tx_coalesce > 1)
-		printk(KERN_INFO "tx_coalesce:\t%d packets\n",
-				tx_coalesce);
-	if (np->coalesce)
-		printk(KERN_INFO
-		       "rx_coalesce:\t%d packets\n"
-		       "rx_timeout: \t%d ns\n",
-				np->rx_coalesce, np->rx_timeout*640);
+		netdev_dbg(dev, "tx_coalesce:\t%d packets", tx_coalesce);
+	if (np->coalesce) {
+		netdev_dbg(dev, "rx_coalesce:\t%d packets", np->rx_coalesce);
+		netdev_dbg(dev, "rx_timeout: \t%d ns", np->rx_timeout * 640);
+	}
 	if (np->vlan)
-		printk(KERN_INFO "vlan(id):\t%d\n", np->vlan);
+		netdev_dbg(dev, "vlan(id):\t%d", np->vlan);
 	return 0;
 
 err_out_unmap_rx:
-- 
2.52.0
Re: [PATCH net-next v2] net: dlink: replace printk() with netdev_{info,dbg}() in rio_probe1()
Posted by Andrew Lunn 1 month ago
On Mon, Jan 05, 2026 at 10:05:53PM +0900, Yeounsu Moon wrote:
> Replace rio_probe1() printk(KERN_INFO) messages with netdev_{info,dbg}().
> 
> Keep one netdev_info() line for device identification; move the rest to
> netdev_dbg() to avoid spamming the kernel log.
> 
> Log rx_timeout on a separate line since netdev_*() prefixes each
> message and the multi-line formatting looks broken otherwise.
> 
> No functional change intended.
> 
> Tested-on: D-Link DGE-550T Rev-A3
> Signed-off-by: Yeounsu Moon <yyyynoom@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew