[PATCH] tee: amdtee: Remove unused return variables

Thorsten Blum posted 1 patch 1 month ago
drivers/tee/amdtee/call.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] tee: amdtee: Remove unused return variables
Posted by Thorsten Blum 1 month ago
In tee_params_to_amd_params() and amd_params_to_tee_params(), return 0
directly and remove the unused return variables.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/tee/amdtee/call.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
index 4c21b02be4af..460b0c9e511f 100644
--- a/drivers/tee/amdtee/call.c
+++ b/drivers/tee/amdtee/call.c
@@ -15,7 +15,7 @@
 static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
 				    struct tee_operation *amd)
 {
-	int i, ret = 0;
+	int i;
 	u32 type;
 
 	if (!count)
@@ -66,13 +66,13 @@ static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
 				 i, amd->params[i].val.b);
 		}
 	}
-	return ret;
+	return 0;
 }
 
 static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
 				    struct tee_operation *amd)
 {
-	int i, ret = 0;
+	int i;
 	u32 type;
 
 	if (!count)
@@ -118,7 +118,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
 				 i, amd->params[i].val.b);
 		}
 	}
-	return ret;
+	return 0;
 }
 
 static DEFINE_MUTEX(ta_refcount_mutex);
-- 
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
Re: [PATCH] tee: amdtee: Remove unused return variables
Posted by Jens Wiklander 3 weeks, 3 days ago
On Mon, Jan 5, 2026 at 1:50 PM Thorsten Blum <thorsten.blum@linux.dev> wrote:
>
> In tee_params_to_amd_params() and amd_params_to_tee_params(), return 0
> directly and remove the unused return variables.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/tee/amdtee/call.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Looks good. I'm picking up this.

Thanks,
Jens

>
> diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
> index 4c21b02be4af..460b0c9e511f 100644
> --- a/drivers/tee/amdtee/call.c
> +++ b/drivers/tee/amdtee/call.c
> @@ -15,7 +15,7 @@
>  static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
>                                     struct tee_operation *amd)
>  {
> -       int i, ret = 0;
> +       int i;
>         u32 type;
>
>         if (!count)
> @@ -66,13 +66,13 @@ static int tee_params_to_amd_params(struct tee_param *tee, u32 count,
>                                  i, amd->params[i].val.b);
>                 }
>         }
> -       return ret;
> +       return 0;
>  }
>
>  static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
>                                     struct tee_operation *amd)
>  {
> -       int i, ret = 0;
> +       int i;
>         u32 type;
>
>         if (!count)
> @@ -118,7 +118,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
>                                  i, amd->params[i].val.b);
>                 }
>         }
> -       return ret;
> +       return 0;
>  }
>
>  static DEFINE_MUTEX(ta_refcount_mutex);
> --
> Thorsten Blum <thorsten.blum@linux.dev>
> GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
>