Switch from the old AES library functions (which use struct
crypto_aes_ctx) to the new ones (which use struct aes_enckey). This
eliminates the unnecessary computation and caching of the decryption
round keys. The new AES en/decryption functions are also much faster
and use AES instructions when supported by the CPU.
Note: aes_encrypt_new() will be renamed to aes_encrypt() once all
callers of the old aes_encrypt() have been updated.
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
drivers/crypto/omap-aes-gcm.c | 6 +++---
drivers/crypto/omap-aes.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c
index 1f4586509ca4..efe94a983589 100644
--- a/drivers/crypto/omap-aes-gcm.c
+++ b/drivers/crypto/omap-aes-gcm.c
@@ -175,11 +175,11 @@ static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd,
static int do_encrypt_iv(struct aead_request *req, u32 *tag, u32 *iv)
{
struct omap_aes_gcm_ctx *ctx = crypto_aead_ctx(crypto_aead_reqtfm(req));
- aes_encrypt(&ctx->actx, (u8 *)tag, (u8 *)iv);
+ aes_encrypt_new(&ctx->akey, (u8 *)tag, (const u8 *)iv);
return 0;
}
void omap_aes_gcm_dma_out_callback(void *data)
{
@@ -312,11 +312,11 @@ int omap_aes_gcm_setkey(struct crypto_aead *tfm, const u8 *key,
unsigned int keylen)
{
struct omap_aes_gcm_ctx *ctx = crypto_aead_ctx(tfm);
int ret;
- ret = aes_expandkey(&ctx->actx, key, keylen);
+ ret = aes_prepareenckey(&ctx->akey, key, keylen);
if (ret)
return ret;
memcpy(ctx->octx.key, key, keylen);
ctx->octx.keylen = keylen;
@@ -332,11 +332,11 @@ int omap_aes_4106gcm_setkey(struct crypto_aead *tfm, const u8 *key,
if (keylen < 4)
return -EINVAL;
keylen -= 4;
- ret = aes_expandkey(&ctx->actx, key, keylen);
+ ret = aes_prepareenckey(&ctx->akey, key, keylen);
if (ret)
return ret;
memcpy(ctx->octx.key, key, keylen);
memcpy(ctx->octx.nonce, key + keylen, 4);
diff --git a/drivers/crypto/omap-aes.h b/drivers/crypto/omap-aes.h
index 99c36a777e97..6aa70bde387a 100644
--- a/drivers/crypto/omap-aes.h
+++ b/drivers/crypto/omap-aes.h
@@ -96,11 +96,11 @@ struct omap_aes_ctx {
struct crypto_skcipher *fallback;
};
struct omap_aes_gcm_ctx {
struct omap_aes_ctx octx;
- struct crypto_aes_ctx actx;
+ struct aes_enckey akey;
};
struct omap_aes_reqctx {
struct omap_aes_dev *dd;
unsigned long mode;
--
2.52.0