[PATCH 08/15] reset: remove unneeded include

Bartosz Golaszewski posted 15 patches 1 month ago
[PATCH 08/15] reset: remove unneeded include
Posted by Bartosz Golaszewski 1 month ago
Reset core does not use any symbols from linux/of_platform.h so there's
no need to include it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/reset/core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index ffb811cbc6460b48dd833d3560d6538eea2fd5c0..48eb64654b6de08030674ce3b994021b5f57060e 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -20,7 +20,6 @@
 #include <linux/kref.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_platform.h>
 #include <linux/reset.h>
 #include <linux/reset-controller.h>
 #include <linux/slab.h>

-- 
2.47.3
Re: [PATCH 08/15] reset: remove unneeded include
Posted by Philipp Zabel 1 month ago
On Mo, 2026-01-05 at 15:15 +0100, Bartosz Golaszewski wrote:
> Reset core does not use any symbols from linux/of_platform.h so there's
> no need to include it.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
>  drivers/reset/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> index ffb811cbc6460b48dd833d3560d6538eea2fd5c0..48eb64654b6de08030674ce3b994021b5f57060e 100644
> --- a/drivers/reset/core.c
> +++ b/drivers/reset/core.c
> @@ -20,7 +20,6 @@
>  #include <linux/kref.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> -#include <linux/of_platform.h>

You added this in patch 2. Can this be squashed into patch 2? Otherwise
squash it into whichever patch makes that addition unnecessary, please.

regards
Philipp
Re: [PATCH 08/15] reset: remove unneeded include
Posted by Bartosz Golaszewski 1 month ago
On Thu, Jan 8, 2026 at 2:59 PM Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
> On Mo, 2026-01-05 at 15:15 +0100, Bartosz Golaszewski wrote:
> > Reset core does not use any symbols from linux/of_platform.h so there's
> > no need to include it.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> > ---
> >  drivers/reset/core.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/reset/core.c b/drivers/reset/core.c
> > index ffb811cbc6460b48dd833d3560d6538eea2fd5c0..48eb64654b6de08030674ce3b994021b5f57060e 100644
> > --- a/drivers/reset/core.c
> > +++ b/drivers/reset/core.c
> > @@ -20,7 +20,6 @@
> >  #include <linux/kref.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> > -#include <linux/of_platform.h>
>
> You added this in patch 2. Can this be squashed into patch 2? Otherwise
> squash it into whichever patch makes that addition unnecessary, please.
>

Gah! Should have git blamed it before complaining. :) Thanks for the catch.

Bartosz