[PATCH 05/15] reset: warn on reset-gpio release

Bartosz Golaszewski posted 15 patches 1 month ago
[PATCH 05/15] reset: warn on reset-gpio release
Posted by Bartosz Golaszewski 1 month ago
While we implement an empty .release() callback for reset-gpio (driver
core requires it), this function will never actually be called as nobody
ever removes the device and the last reference is not dropped anywhere.

This is by design - once created, the reset-gpio device stays in memory.
Make the .release() callback emit a warning, should it ever be called
due to a programming bug.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/reset/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index ec9e4c39e8debd93d59851cfe72fcf44a79ed7e1..e08056e0f67e86ca76ffd3c1951c543a7e490a23 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -821,7 +821,7 @@ static void __reset_control_put_internal(struct reset_control *rstc)
 
 static void reset_gpio_aux_device_release(struct device *dev)
 {
-
+	WARN("reset-gpio device %s should never have been removed", dev_name(dev));
 }
 
 static int reset_create_gpio_aux_device(struct reset_gpio_lookup *rgpio_dev,

-- 
2.47.3