Make the reset name 'stmmaceth-ocp' as deprecated and to use 'ahb' going
forward.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
.../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
index fc445ad5a1f1..4ba06a955fe2 100644
--- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
+++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
@@ -13,8 +13,6 @@ description:
This binding describes the Altera SOCFPGA SoC implementation of the
Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7
families of chips.
- # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that
- # does not validate against net/snps,dwmac.yaml.
select:
properties:
@@ -84,6 +82,15 @@ properties:
- sgmii
- 1000base-x
+ resets:
+ minItems: 1
+
+ reset-names:
+ deprecated: true
+ items:
+ - const: stmmaceth-ocp
+ description: Do not use 'stmmaceth-ocp' going forward, please use 'ahb' instead.
+
rxc-skew-ps:
description: Skew control of RXC pad
--
2.42.0.411.g813d9a9188
On Mon, Jan 05, 2026 at 06:08:22AM -0600, Dinh Nguyen wrote: > Make the reset name 'stmmaceth-ocp' as deprecated and to use 'ahb' going > forward. > > Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> > --- > .../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml > index fc445ad5a1f1..4ba06a955fe2 100644 > --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml > +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml > @@ -13,8 +13,6 @@ description: > This binding describes the Altera SOCFPGA SoC implementation of the > Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7 > families of chips. > - # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that > - # does not validate against net/snps,dwmac.yaml. > > select: > properties: > @@ -84,6 +82,15 @@ properties: > - sgmii > - 1000base-x > > + resets: > + minItems: 1 That's already the min in the referenced schema. > + > + reset-names: > + deprecated: true > + items: > + - const: stmmaceth-ocp This says stmmaceth-ocp is the 1st entry, but it is the 2nd. You can't really fix this to validate a DT using stmmaceth-ocp. I would just drop this. So that leaves this with just dropping the TODO. Rob
On 1/6/26 13:01, Rob Herring wrote: > On Mon, Jan 05, 2026 at 06:08:22AM -0600, Dinh Nguyen wrote: >> Make the reset name 'stmmaceth-ocp' as deprecated and to use 'ahb' going >> forward. >> >> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> >> --- >> .../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml >> index fc445ad5a1f1..4ba06a955fe2 100644 >> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml >> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml >> @@ -13,8 +13,6 @@ description: >> This binding describes the Altera SOCFPGA SoC implementation of the >> Synopsys DWMAC for the Cyclone5, Arria5, Stratix10, Agilex5 and Agilex7 >> families of chips. >> - # TODO: Determine how to handle the Arria10 reset-name, stmmaceth-ocp, that >> - # does not validate against net/snps,dwmac.yaml. >> >> select: >> properties: >> @@ -84,6 +82,15 @@ properties: >> - sgmii >> - 1000base-x >> >> + resets: >> + minItems: 1 > > That's already the min in the referenced schema. > Yeah, I had to add this, else it would fail the 'make dt_binding_check DT_SCHEMA_FILES'. >> + >> + reset-names: >> + deprecated: true >> + items: >> + - const: stmmaceth-ocp > > This says stmmaceth-ocp is the 1st entry, but it is the 2nd. > > You can't really fix this to validate a DT using stmmaceth-ocp. I would > just drop this. So that leaves this with just dropping the TODO. Got it. Thanks, Dinh
© 2016 - 2026 Red Hat, Inc.