[PATCH 3/5] drm/panel: mantix: Improve power off sequence

Sebastian Krzyszkowiak via B4 Relay posted 5 patches 1 month ago
[PATCH 3/5] drm/panel: mantix: Improve power off sequence
Posted by Sebastian Krzyszkowiak via B4 Relay 1 month ago
From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>

According to the sequence from section 7.3.4 of FT8006P datasheet,
TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and
together with VDDI.

Also, AVEE power down needs to happen at least 150ms after entering
sleep mode.

Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
---
 drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
index bb5489e4d7a9..0e66ee7a727d 100644
--- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
+++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
@@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel)
 	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
 	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
 
+	/* T10 */
+	mipi_dsi_msleep(&dsi_ctx, 150);
+
 	return dsi_ctx.accum_err;
 }
 
@@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel)
 {
 	struct mantix *ctx = panel_to_mantix(panel);
 
-	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
-	usleep_range(5000, 6000);
-	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
-
 	regulator_disable(ctx->avee);
 	regulator_disable(ctx->avdd);
 	/* T11 */
 	usleep_range(5000, 6000);
 	regulator_disable(ctx->vddi);
+
+	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
+	usleep_range(5000, 6000);
+	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
 	/* T14 */
 	msleep(50);
 

-- 
2.52.0
Re: [PATCH 3/5] drm/panel: mantix: Improve power off sequence
Posted by Neil Armstrong 1 month ago
On 1/5/26 21:24, Sebastian Krzyszkowiak via B4 Relay wrote:
> From: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> 
> According to the sequence from section 7.3.4 of FT8006P datasheet,
> TP_RSTN and RESX should be asserted after disabling AVDD and AVEE and
> together with VDDI.
> 
> Also, AVEE power down needs to happen at least 150ms after entering
> sleep mode.
> 
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
>   drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> index bb5489e4d7a9..0e66ee7a727d 100644
> --- a/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> +++ b/drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> @@ -96,6 +96,9 @@ static int mantix_disable(struct drm_panel *panel)
>   	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
>   	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
>   
> +	/* T10 */
> +	mipi_dsi_msleep(&dsi_ctx, 150);
> +
>   	return dsi_ctx.accum_err;
>   }
>   
> @@ -103,15 +106,16 @@ static int mantix_unprepare(struct drm_panel *panel)
>   {
>   	struct mantix *ctx = panel_to_mantix(panel);
>   
> -	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
> -	usleep_range(5000, 6000);
> -	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> -
>   	regulator_disable(ctx->avee);
>   	regulator_disable(ctx->avdd);
>   	/* T11 */
>   	usleep_range(5000, 6000);
>   	regulator_disable(ctx->vddi);
> +
> +	gpiod_set_value_cansleep(ctx->tp_rstn_gpio, 1);
> +	usleep_range(5000, 6000);
> +	gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> +
>   	/* T14 */
>   	msleep(50);
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil