mailbox: exynos: drop unneeded runtime pointer (pclk)

[PATCH] mailbox: exynos: drop unneeded runtime pointer (pclk)

Posted by André Draszik 1 month ago

pclk is not needed past probe(), just drop it. This saves a little bit
of runtime memory.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/mailbox/exynos-mailbox.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c
index 2320649bf60c86980c0e8554f2d5fd32af218a6d..5f2d3b81c1dbec8d1a15353769b4b3a1d6ebdf21 100644
--- a/drivers/mailbox/exynos-mailbox.c
+++ b/drivers/mailbox/exynos-mailbox.c
@@ -35,12 +35,10 @@
  * struct exynos_mbox - driver's private data.
  * @regs:	mailbox registers base address.
  * @mbox:	pointer to the mailbox controller.
- * @pclk:	pointer to the mailbox peripheral clock.
  */
 struct exynos_mbox {
 	void __iomem *regs;
 	struct mbox_controller *mbox;
-	struct clk *pclk;
 };
 
 static int exynos_mbox_send_data(struct mbox_chan *chan, void *data)
@@ -100,6 +98,7 @@ static int exynos_mbox_probe(struct platform_device *pdev)
 	struct exynos_mbox *exynos_mbox;
 	struct mbox_controller *mbox;
 	struct mbox_chan *chans;
+	struct clk *pclk;
 	int i;
 
 	exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
@@ -119,9 +118,9 @@ static int exynos_mbox_probe(struct platform_device *pdev)
 	if (IS_ERR(exynos_mbox->regs))
 		return PTR_ERR(exynos_mbox->regs);
 
-	exynos_mbox->pclk = devm_clk_get_enabled(dev, "pclk");
-	if (IS_ERR(exynos_mbox->pclk))
-		return dev_err_probe(dev, PTR_ERR(exynos_mbox->pclk),
+	pclk = devm_clk_get_enabled(dev, "pclk");
+	if (IS_ERR(pclk))
+		return dev_err_probe(dev, PTR_ERR(pclk),
 				     "Failed to enable clock.\n");
 
 	mbox->num_chans = EXYNOS_MBOX_CHAN_COUNT;

---
base-commit: f8f97927abf7c12382dddc93a144fc9df7919b77
change-id: 20260105-mailbox-acpm-pclk-ptr-c25c99dacb34

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Re: [PATCH] mailbox: exynos: drop unneeded runtime pointer (pclk)

Posted by Jassi Brar 3 weeks ago

On Mon, Jan 5, 2026 at 6:34 AM André Draszik <andre.draszik@linaro.org> wrote:
>
> pclk is not needed past probe(), just drop it. This saves a little bit
> of runtime memory.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/mailbox/exynos-mailbox.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mailbox/exynos-mailbox.c b/drivers/mailbox/exynos-mailbox.c
> index 2320649bf60c86980c0e8554f2d5fd32af218a6d..5f2d3b81c1dbec8d1a15353769b4b3a1d6ebdf21 100644
> --- a/drivers/mailbox/exynos-mailbox.c
> +++ b/drivers/mailbox/exynos-mailbox.c
> @@ -35,12 +35,10 @@
>   * struct exynos_mbox - driver's private data.
>   * @regs:      mailbox registers base address.
>   * @mbox:      pointer to the mailbox controller.
> - * @pclk:      pointer to the mailbox peripheral clock.
>   */
>  struct exynos_mbox {
>         void __iomem *regs;
>         struct mbox_controller *mbox;
> -       struct clk *pclk;
>  };
>
>  static int exynos_mbox_send_data(struct mbox_chan *chan, void *data)
> @@ -100,6 +98,7 @@ static int exynos_mbox_probe(struct platform_device *pdev)
>         struct exynos_mbox *exynos_mbox;
>         struct mbox_controller *mbox;
>         struct mbox_chan *chans;
> +       struct clk *pclk;
>         int i;
>
>         exynos_mbox = devm_kzalloc(dev, sizeof(*exynos_mbox), GFP_KERNEL);
> @@ -119,9 +118,9 @@ static int exynos_mbox_probe(struct platform_device *pdev)
>         if (IS_ERR(exynos_mbox->regs))
>                 return PTR_ERR(exynos_mbox->regs);
>
> -       exynos_mbox->pclk = devm_clk_get_enabled(dev, "pclk");
> -       if (IS_ERR(exynos_mbox->pclk))
> -               return dev_err_probe(dev, PTR_ERR(exynos_mbox->pclk),
> +       pclk = devm_clk_get_enabled(dev, "pclk");
> +       if (IS_ERR(pclk))
> +               return dev_err_probe(dev, PTR_ERR(pclk),
>                                      "Failed to enable clock.\n");
>
>         mbox->num_chans = EXYNOS_MBOX_CHAN_COUNT;
>
> ---
> base-commit: f8f97927abf7c12382dddc93a144fc9df7919b77
> change-id: 20260105-mailbox-acpm-pclk-ptr-c25c99dacb34
>
> Best regards,
> --
> André Draszik <andre.draszik@linaro.org>
>
Applied to mailbox/for-next.
Thanks.

Re: [PATCH] mailbox: exynos: drop unneeded runtime pointer (pclk)

Posted by Tudor Ambarus 1 month ago


On 1/5/26 2:34 PM, André Draszik wrote:
> pclk is not needed past probe(), just drop it. This saves a little bit
> of runtime memory.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/mailbox/exynos-mailbox.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)


Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>

Re: [PATCH] mailbox: exynos: drop unneeded runtime pointer (pclk)

Posted by Krzysztof Kozlowski 1 month ago

On 05/01/2026 13:34, André Draszik wrote:
> pclk is not needed past probe(), just drop it. This saves a little bit
> of runtime memory.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/mailbox/exynos-mailbox.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof