[PATCH] optee: update outdated comment

Julia Lawall posted 1 patch 1 month ago
drivers/tee/optee/rpc.c |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] optee: update outdated comment
Posted by Julia Lawall 1 month ago
The function cmd_alloc_suppl() was renamed as
optee_rpc_cmd_alloc_suppl() in commit c51a564a5b48
("optee: isolate smc abi").  Update the comment
accordingly.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 drivers/tee/optee/rpc.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
index ebbbd42b0e3e..97fc5b14db0c 100644
--- a/drivers/tee/optee/rpc.c
+++ b/drivers/tee/optee/rpc.c
@@ -247,8 +247,8 @@ void optee_rpc_cmd_free_suppl(struct tee_context *ctx, struct tee_shm *shm)
 	param.u.value.c = 0;
 
 	/*
-	 * Match the tee_shm_get_from_id() in cmd_alloc_suppl() as secure
-	 * world has released its reference.
+	 * Match the tee_shm_get_from_id() in optee_rpc_cmd_alloc_suppl()
+	 * as secure world has released its reference.
 	 *
 	 * It's better to do this before sending the request to supplicant
 	 * as we'd like to let the process doing the initial allocation to
Re: [PATCH] optee: update outdated comment
Posted by Sumit Garg 1 month ago
On Sun, Jan 04, 2026 at 06:01:19PM +0100, Julia Lawall wrote:
> The function cmd_alloc_suppl() was renamed as
> optee_rpc_cmd_alloc_suppl() in commit c51a564a5b48
> ("optee: isolate smc abi").  Update the comment
> accordingly.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> 
> ---
>  drivers/tee/optee/rpc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
> index ebbbd42b0e3e..97fc5b14db0c 100644
> --- a/drivers/tee/optee/rpc.c
> +++ b/drivers/tee/optee/rpc.c
> @@ -247,8 +247,8 @@ void optee_rpc_cmd_free_suppl(struct tee_context *ctx, struct tee_shm *shm)
>  	param.u.value.c = 0;
>  
>  	/*
> -	 * Match the tee_shm_get_from_id() in cmd_alloc_suppl() as secure
> -	 * world has released its reference.
> +	 * Match the tee_shm_get_from_id() in optee_rpc_cmd_alloc_suppl()
> +	 * as secure world has released its reference.
>  	 *
>  	 * It's better to do this before sending the request to supplicant
>  	 * as we'd like to let the process doing the initial allocation to
>
Re: [PATCH] optee: update outdated comment
Posted by Jens Wiklander 1 month ago
On Mon, Jan 5, 2026 at 6:26 AM Sumit Garg <sumit.garg@kernel.org> wrote:
>
> On Sun, Jan 04, 2026 at 06:01:19PM +0100, Julia Lawall wrote:
> > The function cmd_alloc_suppl() was renamed as
> > optee_rpc_cmd_alloc_suppl() in commit c51a564a5b48
> > ("optee: isolate smc abi").  Update the comment
> > accordingly.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> >
> > ---
> >  drivers/tee/optee/rpc.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

I'm picking up this.

Thanks,
Jens