staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

[PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

Posted by Gideon Adjei 1 month ago

use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument
in arche_platform_set_wake_detect_state. This keeps lines under 80
columns and satisfies kernel style guidelines.

Signed-off-by: Gideon Adjei <gideonadjei.dev@gmail.com>
---
 drivers/staging/greybus/arche-platform.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
index 8aaff4e45660..bb9b3c3c7a2d 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 {
 	struct arche_platform_drvdata *arche_pdata = devid;
 	unsigned long flags;
+	int state;
 
 	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
 
@@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
 				 */
 				if (arche_pdata->wake_detect_state !=
 						WD_STATE_COLDBOOT_START) {
-					arche_platform_set_wake_detect_state(arche_pdata,
-									     WD_STATE_COLDBOOT_TRIG);
+					state = WD_STATE_COLDBOOT_TRIG;
+					arche_platform_set_wake_detect_state(arche_pdata, state);
 					spin_unlock_irqrestore(&arche_pdata->wake_lock,
 							       flags);
 					return IRQ_WAKE_THREAD;
-- 
2.34.1

Re: [PATCH] staging: greybus: replace WD_STATE_COLDBOOT_TRIG with state

Posted by Greg Kroah-Hartman 1 month ago

On Sun, Jan 04, 2026 at 05:25:41AM -0800, Gideon Adjei wrote:
> use state temporary variable to replace WD_STATE_COLDBOOT_TRIG argument
> in arche_platform_set_wake_detect_state. This keeps lines under 80
> columns and satisfies kernel style guidelines.
> 
> Signed-off-by: Gideon Adjei <gideonadjei.dev@gmail.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index 8aaff4e45660..bb9b3c3c7a2d 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -155,6 +155,7 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  {
>  	struct arche_platform_drvdata *arche_pdata = devid;
>  	unsigned long flags;
> +	int state;
>  
>  	spin_lock_irqsave(&arche_pdata->wake_lock, flags);
>  
> @@ -179,8 +180,8 @@ static irqreturn_t arche_platform_wd_irq(int irq, void *devid)
>  				 */
>  				if (arche_pdata->wake_detect_state !=
>  						WD_STATE_COLDBOOT_START) {
> -					arche_platform_set_wake_detect_state(arche_pdata,
> -									     WD_STATE_COLDBOOT_TRIG);
> +					state = WD_STATE_COLDBOOT_TRIG;
> +					arche_platform_set_wake_detect_state(arche_pdata, state);

No, sorry, the original code here is just fine, don't do things like
this just to make checkpatch "quiet".

thanks,

greg k-h