1. Patchew
  2. linux
  3. [PATCH rdma-next 0/6] Batch of unrelated cleanups in IB
  4. View patch

[PATCH rdma-next 2/6] RDMA/core: Avoid exporting module local functions and remove not-used ones

Leon Romanovsky posted 6 patches 1 month ago
[PATCH rdma-next 2/6] RDMA/core: Avoid exporting module local functions and remove not-used ones
Posted by Leon Romanovsky 1 month ago 
From: Parav Pandit <parav@nvidia.com>

Some of the functions are local to the module and some are not used
starting from commit 36783dec8d79 ("RDMA/rxe: Delete deprecated module
parameters interface"). Delete and avoid exporting them.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
---
 drivers/infiniband/core/device.c | 30 ------------------------------
 include/rdma/ib_verbs.h          |  2 --
 2 files changed, 32 deletions(-)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 13e8a1714bbd..0b0efa9d93aa 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -361,34 +361,6 @@ static struct ib_device *__ib_device_get_by_name(const char *name)
 	return NULL;
 }
 
-/**
- * ib_device_get_by_name - Find an IB device by name
- * @name: The name to look for
- * @driver_id: The driver ID that must match (RDMA_DRIVER_UNKNOWN matches all)
- *
- * Find and hold an ib_device by its name. The caller must call
- * ib_device_put() on the returned pointer.
- */
-struct ib_device *ib_device_get_by_name(const char *name,
-					enum rdma_driver_id driver_id)
-{
-	struct ib_device *device;
-
-	down_read(&devices_rwsem);
-	device = __ib_device_get_by_name(name);
-	if (device && driver_id != RDMA_DRIVER_UNKNOWN &&
-	    device->ops.driver_id != driver_id)
-		device = NULL;
-
-	if (device) {
-		if (!ib_device_try_get(device))
-			device = NULL;
-	}
-	up_read(&devices_rwsem);
-	return device;
-}
-EXPORT_SYMBOL(ib_device_get_by_name);
-
 static int rename_compat_devs(struct ib_device *device)
 {
 	struct ib_core_device *cdev;
@@ -2875,7 +2847,6 @@ int ib_add_sub_device(struct ib_device *parent,
 
 	return ret;
 }
-EXPORT_SYMBOL(ib_add_sub_device);
 
 int ib_del_sub_device_and_put(struct ib_device *sub)
 {
@@ -2894,7 +2865,6 @@ int ib_del_sub_device_and_put(struct ib_device *sub)
 
 	return 0;
 }
-EXPORT_SYMBOL(ib_del_sub_device_and_put);
 
 #ifdef CONFIG_INFINIBAND_VIRT_DMA
 int ib_dma_virt_map_sg(struct ib_device *dev, struct scatterlist *sg, int nents)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 6aad66bc5dd7..e92bf2e44fd8 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -4545,8 +4545,6 @@ static inline bool ib_device_try_get(struct ib_device *dev)
 void ib_device_put(struct ib_device *device);
 struct ib_device *ib_device_get_by_netdev(struct net_device *ndev,
 					  enum rdma_driver_id driver_id);
-struct ib_device *ib_device_get_by_name(const char *name,
-					enum rdma_driver_id driver_id);
 struct net_device *ib_get_net_dev_by_params(struct ib_device *dev, u32 port,
 					    u16 pkey, const union ib_gid *gid,
 					    const struct sockaddr *addr);

-- 
2.52.0
Re: [PATCH rdma-next 2/6] RDMA/core: Avoid exporting module local functions and remove not-used ones
Posted by Zhu Yanjun 1 month ago 
在 2026/1/4 5:51, Leon Romanovsky 写道:
> From: Parav Pandit <parav@nvidia.com>
> 
> Some of the functions are local to the module and some are not used
> starting from commit 36783dec8d79 ("RDMA/rxe: Delete deprecated module
> parameters interface"). Delete and avoid exporting them.
> 
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>

Zhu Yanjun

> ---
>   drivers/infiniband/core/device.c | 30 ------------------------------
>   include/rdma/ib_verbs.h          |  2 --
>   2 files changed, 32 deletions(-)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 13e8a1714bbd..0b0efa9d93aa 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -361,34 +361,6 @@ static struct ib_device *__ib_device_get_by_name(const char *name)
>   	return NULL;
>   }
>   
> -/**
> - * ib_device_get_by_name - Find an IB device by name
> - * @name: The name to look for
> - * @driver_id: The driver ID that must match (RDMA_DRIVER_UNKNOWN matches all)
> - *
> - * Find and hold an ib_device by its name. The caller must call
> - * ib_device_put() on the returned pointer.
> - */
> -struct ib_device *ib_device_get_by_name(const char *name,
> -					enum rdma_driver_id driver_id)
> -{
> -	struct ib_device *device;
> -
> -	down_read(&devices_rwsem);
> -	device = __ib_device_get_by_name(name);
> -	if (device && driver_id != RDMA_DRIVER_UNKNOWN &&
> -	    device->ops.driver_id != driver_id)
> -		device = NULL;
> -
> -	if (device) {
> -		if (!ib_device_try_get(device))
> -			device = NULL;
> -	}
> -	up_read(&devices_rwsem);
> -	return device;
> -}
> -EXPORT_SYMBOL(ib_device_get_by_name);
> -
>   static int rename_compat_devs(struct ib_device *device)
>   {
>   	struct ib_core_device *cdev;
> @@ -2875,7 +2847,6 @@ int ib_add_sub_device(struct ib_device *parent,
>   
>   	return ret;
>   }
> -EXPORT_SYMBOL(ib_add_sub_device);
>   
>   int ib_del_sub_device_and_put(struct ib_device *sub)
>   {
> @@ -2894,7 +2865,6 @@ int ib_del_sub_device_and_put(struct ib_device *sub)
>   
>   	return 0;
>   }
> -EXPORT_SYMBOL(ib_del_sub_device_and_put);
>   
>   #ifdef CONFIG_INFINIBAND_VIRT_DMA
>   int ib_dma_virt_map_sg(struct ib_device *dev, struct scatterlist *sg, int nents)
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 6aad66bc5dd7..e92bf2e44fd8 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -4545,8 +4545,6 @@ static inline bool ib_device_try_get(struct ib_device *dev)
>   void ib_device_put(struct ib_device *device);
>   struct ib_device *ib_device_get_by_netdev(struct net_device *ndev,
>   					  enum rdma_driver_id driver_id);
> -struct ib_device *ib_device_get_by_name(const char *name,
> -					enum rdma_driver_id driver_id);
>   struct net_device *ib_get_net_dev_by_params(struct ib_device *dev, u32 port,
>   					    u16 pkey, const union ib_gid *gid,
>   					    const struct sockaddr *addr);
>
Re: [PATCH rdma-next 2/6] RDMA/core: Avoid exporting module local functions and remove not-used ones
Posted by Kalesh Anakkur Purayil 1 month ago 
On Sun, Jan 4, 2026 at 7:22 PM Leon Romanovsky <leon@kernel.org> wrote:
>
> From: Parav Pandit <parav@nvidia.com>
>
> Some of the functions are local to the module and some are not used
> starting from commit 36783dec8d79 ("RDMA/rxe: Delete deprecated module
> parameters interface"). Delete and avoid exporting them.
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>


-- 
Regards,
Kalesh AP

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.