[PATCH 2/2] docs: clarify that dirtytime_expire_seconds=0 disables writeback

Laveesh Bansal posted 2 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 2/2] docs: clarify that dirtytime_expire_seconds=0 disables writeback
Posted by Laveesh Bansal 1 month, 1 week ago
Document that setting vm.dirtytime_expire_seconds to zero disables
periodic dirtytime writeback, matching the behavior of the related
dirty_writeback_centisecs sysctl which already documents this.

Signed-off-by: Laveesh Bansal <laveeshb@laveeshbansal.com>
---
 Documentation/admin-guide/sysctl/vm.rst | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
index 4d71211fdad8..e2fdbc521033 100644
--- a/Documentation/admin-guide/sysctl/vm.rst
+++ b/Documentation/admin-guide/sysctl/vm.rst
@@ -231,6 +231,8 @@ eventually gets pushed out to disk.  This tunable is used to define when dirty
 inode is old enough to be eligible for writeback by the kernel flusher threads.
 And, it is also used as the interval to wakeup dirtytime_writeback thread.
 
+Setting this to zero disables periodic dirtytime writeback.
+
 
 dirty_writeback_centisecs
 =========================
-- 
2.43.0
Re: [PATCH 2/2] docs: clarify that dirtytime_expire_seconds=0 disables writeback
Posted by Jan Kara 1 month ago
On Fri 02-01-26 20:16:57, Laveesh Bansal wrote:
> Document that setting vm.dirtytime_expire_seconds to zero disables
> periodic dirtytime writeback, matching the behavior of the related
> dirty_writeback_centisecs sysctl which already documents this.
> 
> Signed-off-by: Laveesh Bansal <laveeshb@laveeshbansal.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  Documentation/admin-guide/sysctl/vm.rst | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
> index 4d71211fdad8..e2fdbc521033 100644
> --- a/Documentation/admin-guide/sysctl/vm.rst
> +++ b/Documentation/admin-guide/sysctl/vm.rst
> @@ -231,6 +231,8 @@ eventually gets pushed out to disk.  This tunable is used to define when dirty
>  inode is old enough to be eligible for writeback by the kernel flusher threads.
>  And, it is also used as the interval to wakeup dirtytime_writeback thread.
>  
> +Setting this to zero disables periodic dirtytime writeback.
> +
>  
>  dirty_writeback_centisecs
>  =========================
> -- 
> 2.43.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR