Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 drivers/clk/tegra/clk-tegra124-emc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c
index 2a6db0434281..2953b62cb619 100644
--- a/drivers/clk/tegra/clk-tegra124-emc.c
+++ b/drivers/clk/tegra/clk-tegra124-emc.c
@@ -444,7 +444,6 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
 				u32 ram_code)
 {
 	struct emc_timing *timings_ptr;
-	struct device_node *child;
 	int child_count = of_get_child_count(node);
 	int i = 0, err;
 	size_t size;
@@ -458,12 +457,11 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
 	timings_ptr = tegra->timings + tegra->num_timings;
 	tegra->num_timings += child_count;
 
-	for_each_child_of_node(node, child) {
+	for_each_child_of_node_scoped(node, child) {
 		struct emc_timing *timing = timings_ptr + (i++);
 
 		err = load_one_timing_from_dt(tegra, timing, child);
 		if (err) {
-			of_node_put(child);
 			kfree(tegra->timings);
 			return err;
 		}
-- 
2.51.0

From: Thierry Reding <treding@nvidia.com>


On Fri, 02 Jan 2026 13:50:20 +0100, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
> 
> 

Applied, thanks!

[1/1] clk: tegra: tegra124-emc: Simplify with scoped for each OF child loop
      commit: 362b0c81b3a5a3d455577866cee6c300784a2ad8

Best regards,
-- 
Thierry Reding <treding@nvidia.com>

On 02/01/2026 12:50, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>   drivers/clk/tegra/clk-tegra124-emc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/tegra/clk-tegra124-emc.c b/drivers/clk/tegra/clk-tegra124-emc.c
> index 2a6db0434281..2953b62cb619 100644
> --- a/drivers/clk/tegra/clk-tegra124-emc.c
> +++ b/drivers/clk/tegra/clk-tegra124-emc.c
> @@ -444,7 +444,6 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
>   				u32 ram_code)
>   {
>   	struct emc_timing *timings_ptr;
> -	struct device_node *child;
>   	int child_count = of_get_child_count(node);
>   	int i = 0, err;
>   	size_t size;
> @@ -458,12 +457,11 @@ static int load_timings_from_dt(struct tegra_clk_emc *tegra,
>   	timings_ptr = tegra->timings + tegra->num_timings;
>   	tegra->num_timings += child_count;
>   
> -	for_each_child_of_node(node, child) {
> +	for_each_child_of_node_scoped(node, child) {
>   		struct emc_timing *timing = timings_ptr + (i++);
>   
>   		err = load_one_timing_from_dt(tegra, timing, child);
>   		if (err) {
> -			of_node_put(child);
>   			kfree(tegra->timings);
>   			return err;
>   		}


Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon

-- 
nvpublic