staging: media: tegra-video: move shared SoC declarations to headers

[PATCH v3 0/2] staging: media: tegra-video: move shared SoC declarations to headers

Posted by Sun Jian 1 month ago

This series cleans up tegra-video SoC data declarations shared across
translation units by moving them to the corresponding headers, avoiding
local extern declarations in .c files.

No functional change intended.

---
Changes in v3:
  - Wrap the SPARSE warning in patch 1 commit message to <= 75 columns.

Changes in v2:
  - Add the exact sparse warning line to patch 1 commit message.
  - Add patch 2 moving tegra20_vip_soc declaration to vip.h for consistency.

Changes in v1:
  - Initial version.

Sun Jian (2):
  staging: media: tegra-video: move tegra210_csi_soc declaration to
    csi.h
  staging: media: tegra-video: move tegra20_vip_soc declaration to vip.h

 drivers/staging/media/tegra-video/csi.c | 4 ----
 drivers/staging/media/tegra-video/csi.h | 4 ++++
 drivers/staging/media/tegra-video/vip.c | 4 ----
 drivers/staging/media/tegra-video/vip.h | 4 ++++
 4 files changed, 8 insertions(+), 8 deletions(-)

-- 
2.43.0

Re: [PATCH v3 0/2] staging: media: tegra-video: move shared SoC declarations to headers

Posted by Luca Ceresoli 1 month ago

On Fri Jan 2, 2026 at 12:44 PM CET, Sun Jian wrote:
> This series cleans up tegra-video SoC data declarations shared across
> translation units by moving them to the corresponding headers, avoiding
> local extern declarations in .c files.
>
> No functional change intended.
>
> ---
> Changes in v3:
>   - Wrap the SPARSE warning in patch 1 commit message to <= 75 columns.

My understanding and my knowledge of the common practice is that you
shouldn't wrap lines if they are quoting a single path, log message, error
message and the like.

So I think v2 should be applied, not v3. But I'll leave the decision to
maintainers applying the patches.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH v3 0/2] staging: media: tegra-video: move shared SoC declarations to headers

Posted by sun jian 1 month ago

Hi all,

Sorry — I mistakenly replied only to Luca off-thread earlier.
Re-sending the same note here via reply-to-all so everyone in the
thread has the context.

v3 was sent only to silence the Media CI checkpatch warning about >75
columns in the commit message. I agree that for an exact sparse
error/warning line, keeping it unwrapped makes more sense.

So: v2 keeps the original single-line SPARSE message, while v3 only
wraps that line. There are no code changes between v2 and v3.

I’ll defer to the maintainer who picks up the series — if you prefer
one over the other (v2 vs v3) I can follow that convention for the
next revision.

Luca, sorry for the extra mail — posting this publicly to keep the
discussion in one place.

Thanks,
Sun Jian

On Fri, Jan 2, 2026 at 11:53 PM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
> On Fri Jan 2, 2026 at 12:44 PM CET, Sun Jian wrote:
> > This series cleans up tegra-video SoC data declarations shared across
> > translation units by moving them to the corresponding headers, avoiding
> > local extern declarations in .c files.
> >
> > No functional change intended.
> >
> > ---
> > Changes in v3:
> >   - Wrap the SPARSE warning in patch 1 commit message to <= 75 columns.
>
> My understanding and my knowledge of the common practice is that you
> shouldn't wrap lines if they are quoting a single path, log message, error
> message and the like.
>
> So I think v2 should be applied, not v3. But I'll leave the decision to
> maintainers applying the patches.
>
> Luca
>
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com