Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100
SoC. Use SM8550 as a fallback since x1e80100 shares compatibility
with SM8550 UFSHC, enabling reuse of existing support.
Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com>
---
.../bindings/ufs/qcom,sc7180-ufshc.yaml | 38 +++++++++++--------
1 file changed, 23 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
index d94ef4e6b85a..0f6ea7ca06c8 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml
@@ -26,26 +26,34 @@ select:
- qcom,sm8350-ufshc
- qcom,sm8450-ufshc
- qcom,sm8550-ufshc
+ - qcom,x1e80100-ufshc
required:
- compatible
properties:
compatible:
- items:
- - enum:
- - qcom,msm8998-ufshc
- - qcom,qcs8300-ufshc
- - qcom,sa8775p-ufshc
- - qcom,sc7180-ufshc
- - qcom,sc7280-ufshc
- - qcom,sc8180x-ufshc
- - qcom,sc8280xp-ufshc
- - qcom,sm8250-ufshc
- - qcom,sm8350-ufshc
- - qcom,sm8450-ufshc
- - qcom,sm8550-ufshc
- - const: qcom,ufshc
- - const: jedec,ufs-2.0
+ oneOf:
+ - items:
+ - enum:
+ - qcom,x1e80100-ufshc
+ - const: qcom,sm8550-ufshc
+ - const: qcom,ufshc
+ - const: jedec,ufs-2.0
+ - items:
+ - enum:
+ - qcom,msm8998-ufshc
+ - qcom,qcs8300-ufshc
+ - qcom,sa8775p-ufshc
+ - qcom,sc7180-ufshc
+ - qcom,sc7280-ufshc
+ - qcom,sc8180x-ufshc
+ - qcom,sc8280xp-ufshc
+ - qcom,sm8250-ufshc
+ - qcom,sm8350-ufshc
+ - qcom,sm8450-ufshc
+ - qcom,sm8550-ufshc
+ - const: qcom,ufshc
+ - const: jedec,ufs-2.0
reg:
maxItems: 1
--
2.34.1On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote: > Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100 > SoC. Use SM8550 as a fallback since x1e80100 shares compatibility > with SM8550 UFSHC, enabling reuse of existing support. Your last sentence is redundant. "Make devices compatible because they are compatible". Why are they compatible? Or just say that you add a new device fully compatible with SM8550. Write concise and informative statements, not long elaborted paragraphs where only few words are the actual information > > Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com> > --- > .../bindings/ufs/qcom,sc7180-ufshc.yaml | 38 +++++++++++-------- > 1 file changed, 23 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml > index d94ef4e6b85a..0f6ea7ca06c8 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml > @@ -26,26 +26,34 @@ select: > - qcom,sm8350-ufshc > - qcom,sm8450-ufshc > - qcom,sm8550-ufshc > + - qcom,x1e80100-ufshc You don't need this. > required: > - compatible Best regards, Krzysztof
On 1/2/2026 4:55 PM, Krzysztof Kozlowski wrote: > On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote: >> Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100 >> SoC. Use SM8550 as a fallback since x1e80100 shares compatibility >> with SM8550 UFSHC, enabling reuse of existing support. > > Your last sentence is redundant. "Make devices compatible because they > are compatible". Why are they compatible? Or just say that you add a new > device fully compatible with SM8550. Write concise and informative > statements, not long elaborted paragraphs where only few words are the > actual information > ok, i will update in my next patchset. >> >> Signed-off-by: Pradeep P V K <pradeep.pragallapati@oss.qualcomm.com> >> --- >> .../bindings/ufs/qcom,sc7180-ufshc.yaml | 38 +++++++++++-------- >> 1 file changed, 23 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml >> index d94ef4e6b85a..0f6ea7ca06c8 100644 >> --- a/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml >> +++ b/Documentation/devicetree/bindings/ufs/qcom,sc7180-ufshc.yaml >> @@ -26,26 +26,34 @@ select: >> - qcom,sm8350-ufshc >> - qcom,sm8450-ufshc >> - qcom,sm8550-ufshc >> + - qcom,x1e80100-ufshc > > You don't need this. sure, i will update in my next patchset. > >> required: >> - compatible > > Best regards, > Krzysztof >
On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote: > Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100 > SoC. Use SM8550 as a fallback since x1e80100 shares compatibility > with SM8550 UFSHC, enabling reuse of existing support. > Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Best regards, Krzysztof
On 1/2/2026 4:56 PM, Krzysztof Kozlowski wrote: > On Wed, Dec 31, 2025 at 03:49:49PM +0530, Pradeep P V K wrote: >> Add the UFS Host Controller (UFSHC) compatible for Qualcomm x1e80100 >> SoC. Use SM8550 as a fallback since x1e80100 shares compatibility >> with SM8550 UFSHC, enabling reuse of existing support. >> > > Please use subject prefixes matching the subsystem. You can get them for > example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory > your patch is touching. For bindings, the preferred subjects are > explained here: > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > sure, i will update the subject prefix to directory path in my next patchset. > > Best regards, > Krzysztof >
© 2016 - 2026 Red Hat, Inc.