The dt validation stuff expects the name of the opp table
to match a regexp and it currently doesn't.

Update the name to match the regexp.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
---
 arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
index 441a917b88ba..b7d15a3288ad 100644
--- a/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
+++ b/arch/arm/boot/dts/sigmastar/mstar-infinity.dtsi
@@ -9,7 +9,7 @@
 #include <dt-bindings/gpio/msc313-gpio.h>
 
 / {
-	cpu0_opp_table: opp_table0 {
+	cpu0_opp_table: opp-table-0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.51.0

On 31/12/2025 03:55, Daniel Palmer wrote:
> The dt validation stuff expects the name of the opp table
> to match a regexp and it currently doesn't.
> 
> Update the name to match the regexp.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>


These two should be squashed. Don't align node names with bindings per node.

Best regards,
Krzysztof

Hi Krzysztof,

On Wed, 31 Dec 2025 at 16:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> These two should be squashed. Don't align node names with bindings per node.

Sorry, I cannot parse what that means.

Looking at the example in
Documentation/devicetree/bindings/opp/opp-v2.yaml it looks like it
should just be called opp-table?

Cheers,

Daniel

On 31/12/2025 09:35, Daniel Palmer wrote:
> Hi Krzysztof,
> 
> On Wed, 31 Dec 2025 at 16:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> These two should be squashed. Don't align node names with bindings per node.
> 
> Sorry, I cannot parse what that means.

I meant, two commits should be rather squashed. If you intend to rename
the nodes, fix all names to be generic, not only some.

Best regards,
Krzysztof

Hi Krzysztof,

On Wed, 31 Dec 2025 at 18:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> I meant, two commits should be rather squashed. If you intend to rename
> the nodes, fix all names to be generic, not only some.

There are 3 commits that correct node names:
arm: dts: mstar: breadbee: Correct regulator names
arm: dts: mstar: breadbee: Correct LED names
arm: dts: mstar: infinity: Correct opp table name

The top two are in the same dts board file, the bottom one is in a
different dtsi file for a chip family.
Should I squash all of them into one commit, squash the top two for
the same board into one commit?

Cheers,

Daniel

On 31/12/2025 11:17, Daniel Palmer wrote:
> Hi Krzysztof,
> 
> On Wed, 31 Dec 2025 at 18:48, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> I meant, two commits should be rather squashed. If you intend to rename
>> the nodes, fix all names to be generic, not only some.
> 
> There are 3 commits that correct node names:
> arm: dts: mstar: breadbee: Correct regulator names
> arm: dts: mstar: breadbee: Correct LED names
> arm: dts: mstar: infinity: Correct opp table name
> 
> The top two are in the same dts board file, the bottom one is in a
> different dtsi file for a chip family.

You are right, so it's fine.
> Should I squash all of them into one commit, squash the top two for
> the same board into one commit?



Best regards,
Krzysztof