iio: imu: inv-mpu9150: fix interrupts for MPU9150

[PATCH 2/2] ARM: dts: ti/omap: omap4-epson-embt2ws: fix typo in iio device property

Posted by akemnade@kernel.org 1 month, 1 week ago

From: Andreas Kemnade <andreas@kemnade.info>

Define interrupts properly. Unfortunately, this hides a bug in the linux
driver, so it needs to be used with the driver fixed only.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
index c90f43cc2fae9..a9f0cfd7c999d 100644
--- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
+++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
@@ -346,7 +346,7 @@ mpu9150h: imu@68 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&mpu9150h_pins>;
 		interrupt-parent = <&gpio2>;
-		interrupt = <19 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
 	};
 };
 
@@ -408,7 +408,7 @@ mpu9150: imu@68 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&mpu9150_pins>;
 		interrupt-parent = <&gpio2>;
-		interrupt = <7 IRQ_TYPE_LEVEL_HIGH>;
+		interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
 		vddio-supply = <&cb_v18>;
 		vdd-supply = <&cb_v33>;
 		invensense,level-shifter;

-- 
2.47.3

Re: [PATCH 2/2] ARM: dts: ti/omap: omap4-epson-embt2ws: fix typo in iio device property

Posted by Jonathan Cameron 4 weeks ago

On Wed, 31 Dec 2025 22:14:17 +0100
akemnade@kernel.org wrote:

> From: Andreas Kemnade <andreas@kemnade.info>
> 
> Define interrupts properly. Unfortunately, this hides a bug in the linux
> driver, so it needs to be used with the driver fixed only.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Not related to patch 1 so if TI soc folk can pick this up that would be
great.

> ---
>  arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> index c90f43cc2fae9..a9f0cfd7c999d 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> +++ b/arch/arm/boot/dts/ti/omap/omap4-epson-embt2ws.dts
> @@ -346,7 +346,7 @@ mpu9150h: imu@68 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&mpu9150h_pins>;
>  		interrupt-parent = <&gpio2>;
> -		interrupt = <19 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupts = <19 IRQ_TYPE_LEVEL_HIGH>;
>  	};
>  };
>  
> @@ -408,7 +408,7 @@ mpu9150: imu@68 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&mpu9150_pins>;
>  		interrupt-parent = <&gpio2>;
> -		interrupt = <7 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupts = <7 IRQ_TYPE_LEVEL_HIGH>;
>  		vddio-supply = <&cb_v18>;
>  		vdd-supply = <&cb_v33>;
>  		invensense,level-shifter;
>

Re: [PATCH 2/2] ARM: dts: ti/omap: omap4-epson-embt2ws: fix typo in iio device property

Posted by Andreas Kemnade 3 weeks, 6 days ago

On Sun, 11 Jan 2026 12:32:00 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 31 Dec 2025 22:14:17 +0100
> akemnade@kernel.org wrote:
> 
> > From: Andreas Kemnade <andreas@kemnade.info>
> > 
> > Define interrupts properly. Unfortunately, this hides a bug in the linux
> > driver, so it needs to be used with the driver fixed only.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Not related to patch 1 so if TI soc folk can pick this up that would be
> great.
> 
well, it needs things fixed via patch 1 to avoid creating havoc...
But from a strictly dogmatic point of view the devicetree describes the
hardware, so it is unrelated.
... but from a more pragmatic point of view, I do not want to have interrupts
enabled for drivers which do not handle them correctly.

Of course this should be picked up by omap folks.

Regards,
Andreas

Re: [PATCH 2/2] ARM: dts: ti/omap: omap4-epson-embt2ws: fix typo in iio device property

Posted by Kevin Hilman 3 weeks, 3 days ago

Andreas Kemnade <andreas@kemnade.info> writes:

> On Sun, 11 Jan 2026 12:32:00 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
>> On Wed, 31 Dec 2025 22:14:17 +0100
>> akemnade@kernel.org wrote:
>> 
>> > From: Andreas Kemnade <andreas@kemnade.info>
>> > 
>> > Define interrupts properly. Unfortunately, this hides a bug in the linux
>> > driver, so it needs to be used with the driver fixed only.
>> > 
>> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>  
>> 
>> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>> Not related to patch 1 so if TI soc folk can pick this up that would be
>> great.
>> 
> well, it needs things fixed via patch 1 to avoid creating havoc...
> But from a strictly dogmatic point of view the devicetree describes the
> hardware, so it is unrelated.
> ... but from a more pragmatic point of view, I do not want to have interrupts
> enabled for drivers which do not handle them correctly.
>
> Of course this should be picked up by omap folks.

Based on the changelog comments, I will pick up the DT patch when the
driver fix gets applied.

Kevin