[PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS

Javier Rodriguez posted 5 patches 1 month, 1 week ago
[PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS
Posted by Javier Rodriguez 1 month, 1 week ago
From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>

The MODULE_ALIAS() is redundant since the module alias is now
automatically generated from the MODULE_DEVICE_TABLE().

Remove the explicit alias.

No functional change intended.

Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
Cc: Johannes Thumshirn <jth@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-watchdog@vger.kernel.org
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
 drivers/watchdog/menz69_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
index 6e5e4e5c0b56..3fe23451135d 100644
--- a/drivers/watchdog/menz69_wdt.c
+++ b/drivers/watchdog/menz69_wdt.c
@@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
 MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
 MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
 MODULE_LICENSE("GPL v2");
-MODULE_ALIAS("mcb:16z069");
 MODULE_IMPORT_NS("MCB");
-- 
2.52.0
Re: [PATCH 5/5] watchdog: menz069_wdt: drop unneeded MODULE_ALIAS
Posted by Guenter Roeck 1 month, 1 week ago
On Tue, Dec 30, 2025 at 10:59:28PM +0100, Javier Rodriguez wrote:
> From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> 
> The MODULE_ALIAS() is redundant since the module alias is now
> automatically generated from the MODULE_DEVICE_TABLE().
> 

Unless the generated alias is not "mcb:16z069", and it is unlikely that
it is. That means it is not really redundant.

Guenter

> Remove the explicit alias.
> 
> No functional change intended.
> 
> Fixes: 1f4ea4838b13 ("mcb: Add missing modpost build support")
> Reviewed-by: Jorge Sanjuan Garcia <dev-jorge.sanjuangarcia@duagon.com>
> Cc: Johannes Thumshirn <jth@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Andy Shevchenko <andriy.shevchenko@intel.com>
> Cc: linux-watchdog@vger.kernel.org
> Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
> ---
>  drivers/watchdog/menz69_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/menz69_wdt.c b/drivers/watchdog/menz69_wdt.c
> index 6e5e4e5c0b56..3fe23451135d 100644
> --- a/drivers/watchdog/menz69_wdt.c
> +++ b/drivers/watchdog/menz69_wdt.c
> @@ -163,5 +163,4 @@ module_mcb_driver(men_z069_driver);
>  MODULE_AUTHOR("Johannes Thumshirn <jth@kernel.org>");
>  MODULE_DESCRIPTION("Watchdog driver for the MEN z069 IP-Core");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("mcb:16z069");
>  MODULE_IMPORT_NS("MCB");
> -- 
> 2.52.0