crypto: inside-secure/eip93 - fix kernel panic in driver detach

[PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach

Posted by Aleksander Jan Bajkowski 1 month, 1 week ago

During driver detach, the same hash algorithm is unregistered multiple
times due to a wrong iterator.

Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
 drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c
index 0b38a567da0e..3cdc3308dcac 100644
--- a/drivers/crypto/inside-secure/eip93/eip93-main.c
+++ b/drivers/crypto/inside-secure/eip93/eip93-main.c
@@ -90,7 +90,7 @@ static void eip93_unregister_algs(unsigned int i)
 			crypto_unregister_aead(&eip93_algs[j]->alg.aead);
 			break;
 		case EIP93_ALG_TYPE_HASH:
-			crypto_unregister_ahash(&eip93_algs[i]->alg.ahash);
+			crypto_unregister_ahash(&eip93_algs[j]->alg.ahash);
 			break;
 		}
 	}
-- 
2.47.3

Re: [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach

Posted by Herbert Xu 2 weeks, 1 day ago

On Tue, Dec 30, 2025 at 10:17:17PM +0100, Aleksander Jan Bajkowski wrote:
> During driver detach, the same hash algorithm is unregistered multiple
> times due to a wrong iterator.
> 
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
>  drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure/eip93 - fix kernel panic in driver detach

Posted by Antoine Tenart 1 month ago

On Tue, Dec 30, 2025 at 10:17:17PM +0100, Aleksander Jan Bajkowski wrote:
> During driver detach, the same hash algorithm is unregistered multiple
> times due to a wrong iterator.
> 
> Fixes: 9739f5f93b78 ("crypto: eip93 - Add Inside Secure SafeXcel EIP-93 crypto engine support")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>

Reviewed-by: Antoine Tenart <atenart@kernel.org>

Thanks!

> ---
>  drivers/crypto/inside-secure/eip93/eip93-main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/crypto/inside-secure/eip93/eip93-main.c b/drivers/crypto/inside-secure/eip93/eip93-main.c
> index 0b38a567da0e..3cdc3308dcac 100644
> --- a/drivers/crypto/inside-secure/eip93/eip93-main.c
> +++ b/drivers/crypto/inside-secure/eip93/eip93-main.c
> @@ -90,7 +90,7 @@ static void eip93_unregister_algs(unsigned int i)
>  			crypto_unregister_aead(&eip93_algs[j]->alg.aead);
>  			break;
>  		case EIP93_ALG_TYPE_HASH:
> -			crypto_unregister_ahash(&eip93_algs[i]->alg.ahash);
> +			crypto_unregister_ahash(&eip93_algs[j]->alg.ahash);
>  			break;
>  		}
>  	}
> -- 
> 2.47.3
>