On 12/30, Tomas Borquez wrote:
> Use devm_mutex_init() for automatic resource cleanup when the device
> is removed or probe fails.
>
> Signed-off-by: Tomas Borquez <tomasborquez13@gmail.com>
> ---
> drivers/staging/iio/frequency/ad9832.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c
> index 35d8d51d5c2b..4bb203a67046 100644
> --- a/drivers/staging/iio/frequency/ad9832.c
> +++ b/drivers/staging/iio/frequency/ad9832.c
> @@ -310,7 +310,9 @@ static int ad9832_probe(struct spi_device *spi)
> return dev_err_probe(dev, PTR_ERR(st->mclk), "failed to enable MCLK\n");
>
> st->spi = spi;
> - mutex_init(&st->lock);
> + ret = devm_mutex_init(&spi->dev, &st->lock);
Can use just 'dev' instead of '&spi->dev' after the update from patch 1.
With that
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> + if (ret)
> + return dev_err_probe(dev, ret, "failed to initialize mutex\n");
>
> indio_dev->name = spi_get_device_id(spi)->name;
> indio_dev->info = &ad9832_info;
> --
> 2.43.0
>
>