[PATCH 1/6] dt-bindings: serial: google,goldfish-tty: Convert to DT schema

Kuan-Wei Chiu posted 6 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH 1/6] dt-bindings: serial: google,goldfish-tty: Convert to DT schema
Posted by Kuan-Wei Chiu 1 month, 1 week ago
Convert the Google Goldfish TTY binding to DT schema format.
Move the file to the serial directory to match the subsystem.
Update the example node name to 'serial' to comply with generic node
naming standards.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
 .../devicetree/bindings/goldfish/tty.txt      | 17 ---------
 .../bindings/serial/google,goldfish-tty.yaml  | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/tty.txt
 create mode 100644 Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml

diff --git a/Documentation/devicetree/bindings/goldfish/tty.txt b/Documentation/devicetree/bindings/goldfish/tty.txt
deleted file mode 100644
index 82648278da77..000000000000
--- a/Documentation/devicetree/bindings/goldfish/tty.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-Android Goldfish TTY
-
-Android goldfish tty device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-tty" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	goldfish_tty@1f004000 {
-		compatible = "google,goldfish-tty";
-		reg = <0x1f004000 0x1000>;
-		interrupts = <0xc>;
-	};
diff --git a/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
new file mode 100644
index 000000000000..08fa12449a01
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/google,goldfish-tty.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Google Goldfish TTY
+
+maintainers:
+  - Kuan-Wei Chiu <visitorckw@gmail.com>
+
+description:
+  Android goldfish TTY device generated by Android emulator.
+
+properties:
+  compatible:
+    const: google,goldfish-tty
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    serial@1f004000 {
+        compatible = "google,goldfish-tty";
+        reg = <0x1f004000 0x1000>;
+        interrupts = <0xc>;
+    };
-- 
2.52.0.358.g0dd7633a29-goog
Re: [PATCH 1/6] dt-bindings: serial: google,goldfish-tty: Convert to DT schema
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Tue, Dec 30, 2025 at 06:10:26PM +0000, Kuan-Wei Chiu wrote:
> Convert the Google Goldfish TTY binding to DT schema format.
> Move the file to the serial directory to match the subsystem.
> Update the example node name to 'serial' to comply with generic node
> naming standards.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
> ---
>  .../devicetree/bindings/goldfish/tty.txt      | 17 ---------
>  .../bindings/serial/google,goldfish-tty.yaml  | 38 +++++++++++++++++++
>  2 files changed, 38 insertions(+), 17 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/goldfish/tty.txt
>  create mode 100644 Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> 
> diff --git a/Documentation/devicetree/bindings/goldfish/tty.txt b/Documentation/devicetree/bindings/goldfish/tty.txt
> deleted file mode 100644
> index 82648278da77..000000000000
> --- a/Documentation/devicetree/bindings/goldfish/tty.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -Android Goldfish TTY
> -
> -Android goldfish tty device generated by android emulator.
> -
> -Required properties:
> -
> -- compatible : should contain "google,goldfish-tty" to match emulator
> -- reg        : <registers mapping>
> -- interrupts : <interrupt mapping>
> -
> -Example:
> -
> -	goldfish_tty@1f004000 {
> -		compatible = "google,goldfish-tty";
> -		reg = <0x1f004000 0x1000>;
> -		interrupts = <0xc>;
> -	};
> diff --git a/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> new file mode 100644
> index 000000000000..08fa12449a01
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/google,goldfish-tty.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Google Goldfish TTY
> +
> +maintainers:
> +  - Kuan-Wei Chiu <visitorckw@gmail.com>
> +

Missing allOf to /schemas/serial/serial, unless this is not a serial, but then your
commit msg should explain that.

Best regards,
Krzysztof